Skip to content

Commit 8870af7

Browse files
committed
Remove stale JSON inline test and fix CI failure
The testJsonInlineChunkedResults_withoutArrow test and its WireMock recordings used JSON_ARRAY format which no longer matches driver requests now that Arrow is always enabled. Remove the test and recordings — chunked Arrow results are covered by MultiChunkExecutionIntegrationTests and SqlExecApiHybridResultsIntegrationTests. Also restructure BREAKING CHANGES section in NEXT_CHANGELOG.md with sub-sections for Metadata JDBC Spec Compliance and Default Behavior Changes. Co-authored-by: Isaac Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
1 parent 189fa99 commit 8870af7

5 files changed

Lines changed: 8 additions & 162 deletions

File tree

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,12 @@
11
package com.databricks.jdbc.integration.fakeservice.tests;
22

3-
import static com.databricks.jdbc.integration.IntegrationTestUtil.getValidJDBCConnection;
4-
import static org.junit.jupiter.api.Assertions.assertEquals;
5-
63
import com.databricks.jdbc.integration.fakeservice.AbstractFakeServiceIntegrationTests;
7-
import java.sql.Connection;
8-
import java.sql.ResultSet;
9-
import java.sql.SQLException;
10-
import java.sql.Statement;
11-
import java.util.Properties;
12-
import org.junit.jupiter.api.Test;
13-
14-
public class SqlExecApiIntegrationTests extends AbstractFakeServiceIntegrationTests {
15-
16-
@Test
17-
void testChunkedResults_enableArrowDeprecatedIgnored() throws SQLException {
18-
// EnableArrow=0 is deprecated and ignored on non-AIX — Arrow is always enabled.
19-
// This test verifies the query still succeeds with the deprecated flag set.
20-
final String table = "samples.tpch.lineitem";
21-
final int maxRows = 64000;
22-
final String sql = "SELECT * FROM " + table + " limit " + maxRows;
23-
24-
Properties properties = new Properties();
25-
properties.setProperty("EnableArrow", "0");
26-
Connection connection = getValidJDBCConnection(properties);
274

28-
final Statement stmt = connection.createStatement();
29-
ResultSet rs = stmt.executeQuery(sql);
30-
int rowCount = 0;
31-
while (rs.next()) {
32-
rowCount++;
33-
}
34-
assertEquals(maxRows, rowCount);
35-
}
36-
}
5+
/**
6+
* SQL Exec API integration tests. The original JSON inline chunked results test
7+
* (testJsonInlineChunkedResults_withoutArrow) was removed because EnableArrow=0 is now deprecated
8+
* and ignored — Arrow is always enabled on non-AIX platforms. The WireMock recordings were captured
9+
* with JSON_ARRAY format which no longer matches the driver's requests. Chunked Arrow results are
10+
* covered by MultiChunkExecutionIntegrationTests and SqlExecApiHybridResultsIntegrationTests.
11+
*/
12+
public class SqlExecApiIntegrationTests extends AbstractFakeServiceIntegrationTests {}

src/test/resources/sqlexecapi/sqlexecapiintegrationtests/testjsoninlinechunkedresults_withoutarrow/mappings/api_2.0_sql_sessions-344861bc-8e95-4d1c-889d-cbd425906d03.json

Lines changed: 0 additions & 35 deletions
This file was deleted.

src/test/resources/sqlexecapi/sqlexecapiintegrationtests/testjsoninlinechunkedresults_withoutarrow/mappings/api_2.0_sql_statements-994cb021-b4be-45d7-9626-3ba0a8911bf0.json

Lines changed: 0 additions & 35 deletions
This file was deleted.

src/test/resources/sqlexecapi/sqlexecapiintegrationtests/testjsoninlinechunkedresults_withoutarrow/mappings/api_2.0_sql_statements_01f0bfa3-978a-1459-a201-bc371ea1a343_result_chunks_1-3ceb1fd2-517b-44a9-a8ef-334a4a6b00df.json

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/test/resources/sqlexecapi/sqlexecapiintegrationtests/testjsoninlinechunkedresults_withoutarrow/mappings/oidc_.well-known_oauth-authorization-server-289b87a6-490d-41f3-934d-228ad6e305ec.json

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)