geospatial fixes (#1062)

## Description
<!-- Provide a brief summary of the changes made and the issue they aim
to address.-->

This PR addresses comments from Milan's review on PR #988 (Geospatial
support implementation).

  ## Changes

  ### 1. Cache WKB Value for Performance
- Added `wkb` field to `AbstractDatabricksGeospatial` to cache WKB
representation
- WKB now computed once in constructor instead of on every `getWKB()`
call

  ### 2. Simplify SRID Extraction Logic
  - Removed metadata-based SRID extraction entirely
- Per Milan's clarification: "SRID is always present in EWKT unless it's
0"
- Simplified `convertToGeospatial()` to only extract SRID from EWKT data
  - Removed `extractSRIDFromMetadata()` method and regex patterns
- Removed unused `arrowMetadata` parameter from `convertToGeospatial()`

  ## Testing
  - All unit tests are passing

## Additional Notes to the Reviewer
<!-- Share any additional context or insights that may help the reviewer
understand the changes better. This could include challenges faced,
limitations, or compromises made during the development process.
Also, mention any areas of the code that you would like the reviewer to
focus on specifically. -->


NO_CHANGELOG=true
(changelog already added in previous PR)

Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>

Author: sreekanth-db

src/main/java/com/databricks/jdbc/api/impl/AbstractDatabricksGeospatial.java

@@ -20,6 +20,7 @@ public abstract class AbstractDatabricksGeospatial implements IDatabricksGeospat
 
   private final String wkt;
   private final int srid; // Spatial Reference System Identifier
+  private final byte[] wkb;
 
   /**
    * Constructs an AbstractDatabricksGeospatial with the specified WKT and SRID.
@@ -37,17 +38,17 @@ protected AbstractDatabricksGeospatial(String wkt, int srid)
 
     this.wkt = wkt.trim();
     this.srid = srid;
+    this.wkb = WKTConverter.toWKB(this.wkt);
   }
 
   /**
    * Returns the Well-Known Binary (WKB) representation of the geospatial object.
    *
    * @return the WKB representation as a byte array
-   * @throws DatabricksValidationException if WKT to WKB conversion fails
    */
   @Override
-  public byte[] getWKB() throws DatabricksValidationException {
-    return WKTConverter.toWKB(wkt);
+  public byte[] getWKB() {
+    return wkb;
   }
 
   /**

src/main/java/com/databricks/jdbc/api/impl/converters/ArrowToJavaObjectConverter.java

@@ -10,7 +10,6 @@
 import com.databricks.jdbc.log.JdbcLoggerFactory;
 import com.databricks.jdbc.model.core.ColumnInfo;
 import com.databricks.jdbc.model.core.ColumnInfoTypeName;
-import com.databricks.jdbc.model.telemetry.enums.DatabricksDriverErrorCode;
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 import java.sql.Date;
@@ -22,8 +21,6 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.function.Function;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
 import org.apache.arrow.vector.TimeStampMicroTZVector;
 import org.apache.arrow.vector.ValueVector;
 import org.apache.arrow.vector.util.Text;
@@ -32,10 +29,6 @@ public class ArrowToJavaObjectConverter {
   private static final JdbcLogger LOGGER =
       JdbcLoggerFactory.getLogger(ArrowToJavaObjectConverter.class);
 
-  // Pre-compiled patterns for SRID extraction from metadata
-  private static final Pattern GEOMETRY_SRID_PATTERN = Pattern.compile("GEOMETRY\\((\\d+)\\)");
-  private static final Pattern GEOGRAPHY_SRID_PATTERN = Pattern.compile("GEOGRAPHY\\((\\d+)\\)");
-
   private static final List<DateTimeFormatter> DATE_FORMATTERS =
       Arrays.asList(
           DateTimeFormatter.ofPattern("yyyy-MM-dd"),
@@ -148,7 +141,7 @@ public static Object convert(
         return ic.toLiteral(object);
       case GEOMETRY:
       case GEOGRAPHY:
-        return convertToGeospatial(object, arrowMetadata, requiredType);
+        return convertToGeospatial(object, requiredType);
       case NULL:
         return null;
       default:
@@ -177,23 +170,18 @@ private static Object convertToStruct(Object object, String arrowMetadata)
   }
 
   private static AbstractDatabricksGeospatial convertToGeospatial(
-      Object object, String arrowMetadata, ColumnInfoTypeName type) throws DatabricksSQLException {
+      Object object, ColumnInfoTypeName type) throws DatabricksSQLException {
     String ewkt = convertToString(object);
 
-    // Parse EWKT to extract SRID from data if present
-    int dataSrid = WKTConverter.extractSRIDFromEWKT(ewkt);
+    // Parse EWKT to extract SRID from data
+    // SRID is always present in EWKT unless it's 0, in which case it is handled in
+    // WKTConverter.extractSRIDFromEWKT()
+    int srid = WKTConverter.extractSRIDFromEWKT(ewkt);
     String cleanWkt = WKTConverter.removeSRIDFromEWKT(ewkt);
 
-    // Extract SRID from metadata if not present in data
-    int finalSrid = dataSrid;
-    if (dataSrid == 0) {
-      String typeName = type == ColumnInfoTypeName.GEOMETRY ? GEOMETRY : GEOGRAPHY;
-      finalSrid = extractSRIDFromMetadata(arrowMetadata, typeName);
-    }
-
     return type == ColumnInfoTypeName.GEOMETRY
-        ? new DatabricksGeometry(cleanWkt, finalSrid)
-        : new DatabricksGeography(cleanWkt, finalSrid);
+        ? new DatabricksGeometry(cleanWkt, srid)
+        : new DatabricksGeography(cleanWkt, srid);
   }
 
   private static Object convertToTimestamp(Object object, Optional<String> timeZoneOpt)
@@ -327,43 +315,4 @@ private static <T extends Number> T convertToNumber(
     LOGGER.error(errorMessage);
     throw new DatabricksValidationException(errorMessage);
   }
-
-  /**
-   * Extracts SRID from Arrow metadata string.
-   *
-   * @param metadata Arrow metadata like "GEOMETRY(32633)" or "GEOGRAPHY(4326)"
-   * @param typePrefix The prefix to look for ("GEOMETRY" or "GEOGRAPHY")
-   * @return SRID value, or 0 if not found
-   * @throws DatabricksParsingException if metadata format is invalid
-   */
-  private static int extractSRIDFromMetadata(String metadata, String typePrefix)
-      throws DatabricksParsingException {
-    if (metadata == null) {
-      LOGGER.debug("Metadata is null, returning default SRID 0 for {}", typePrefix);
-      return 0;
-    }
-
-    try {
-      // Look for pattern like "GEOMETRY(32633)" or "GEOGRAPHY(4326)"
-      Pattern pattern =
-          typePrefix.equals(GEOMETRY) ? GEOMETRY_SRID_PATTERN : GEOGRAPHY_SRID_PATTERN;
-      Matcher m = pattern.matcher(metadata);
-
-      if (m.find()) {
-        return Integer.parseInt(m.group(1));
-      }
-    } catch (Exception e) {
-      String errorMessage =
-          String.format("Failed to parse SRID from %s metadata: %s", typePrefix, metadata);
-      LOGGER.error(errorMessage, e);
-      throw new DatabricksParsingException(
-          errorMessage, e, DatabricksDriverErrorCode.RESULT_SET_ERROR);
-    }
-
-    LOGGER.debug(
-        "No SRID found in metadata for {}, returning default SRID 0. Metadata: {}",
-        typePrefix,
-        metadata);
-    return 0;
-  }
 }