Commit 995a9d7
authored
Fix flaky test ChunkLinkDownloadServiceTest#testBatchDownloadChaining (#811)
The link download futures were being completed because the link download chain was triggered eagerly. When getLinkForChunk is called, the link download future is evaluated. If the future is already complete, it checks the status of the chunk. The test was not mocking the chunk, which caused a NullPointerException (NPE). Locally, the test passed because the link download futures weren't completing before getLinkForChunk was called. However, in the GitHub runs, the futures were completing, which led to a thread synchronization issue.1 parent 2f2814c commit 995a9d7
1 file changed
Lines changed: 3 additions & 0 deletions
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
209 | 212 | | |
210 | 213 | | |
211 | 214 | | |
| |||
0 commit comments