Commit b9b93af
committed
Address review feedback: AIX default, log level, stale tests
- AIX/PowerPC: default to Arrow disabled (was enabled). Honour explicit
EnableArrow=1 if user sets it. Added isAixOrPowerPc() helper.
- Restore client-type guard for AIX — prevents routing to SEA when
Arrow is disabled on AIX.
- Log deprecation at INFO (not WARN) — logged once at connection init,
not per statement.
- Updated changelog to mention PowerPC architectures explicitly.
- Renamed stale/contradictory tests:
testClientTypeWhenArrowDisabled → clarified as non-AIX behavior
testJsonInlineChunkedResults_withoutArrow → deprecated flag test
- Added 2 new tests: default Arrow=true, explicit disable ignored.
Co-authored-by: Isaac
Signed-off-by: Gopal Lal <gopal.lal@databricks.com>1 parent da555af commit b9b93af
4 files changed
Lines changed: 46 additions & 12 deletions
File tree
- src
- main/java/com/databricks/jdbc/api/impl
- test/java/com/databricks/jdbc
- api/impl
- integration/fakeservice/tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
Lines changed: 21 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
505 | 505 | | |
506 | 506 | | |
507 | 507 | | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
508 | 512 | | |
509 | 513 | | |
510 | 514 | | |
| |||
668 | 672 | | |
669 | 673 | | |
670 | 674 | | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
676 | 683 | | |
677 | 684 | | |
678 | | - | |
| 685 | + | |
679 | 686 | | |
680 | 687 | | |
681 | | - | |
| 688 | + | |
682 | 689 | | |
683 | 690 | | |
684 | 691 | | |
| |||
1213 | 1220 | | |
1214 | 1221 | | |
1215 | 1222 | | |
| 1223 | + | |
| 1224 | + | |
| 1225 | + | |
| 1226 | + | |
| 1227 | + | |
| 1228 | + | |
| 1229 | + | |
1216 | 1230 | | |
1217 | 1231 | | |
1218 | 1232 | | |
| |||
Lines changed: 21 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
361 | 376 | | |
362 | 377 | | |
363 | 378 | | |
| |||
947 | 962 | | |
948 | 963 | | |
949 | 964 | | |
950 | | - | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
951 | 968 | | |
952 | 969 | | |
953 | 970 | | |
| |||
969 | 986 | | |
970 | 987 | | |
971 | 988 | | |
972 | | - | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
973 | 992 | | |
974 | 993 | | |
975 | 994 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | | - | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
0 commit comments