Commit dee4266
authored
Add fix for incorrect timestamp issue (#1118)
## Description
Fixes #1116
## Testing
Tested E2E using the following test (also verified that the legacy
driver has the same behavior)
```
@test
void example_TimestampMicrosecondPrecisionWithCalendar() throws Exception {
//create connection first.
try {
String tableName = "default.samikshyananosecondtesting";
Statement stmt = con.createStatement();
stmt.execute(
"CREATE TABLE IF NOT EXISTS " + tableName + " (id INT, ts TIMESTAMP) USING DELTA");
System.out.println("Created test table: " + tableName);
String insertSql = "INSERT INTO " + tableName + " VALUES (?, ?)";
PreparedStatement pstmt = con.prepareStatement(insertSql);
java.sql.Timestamp originalTs = java.sql.Timestamp.valueOf("2025-11-21 23:30:49.185645");
assertEquals(
185645000, originalTs.getNanos(), "Original timestamp should have microsecond precision");
pstmt.setInt(1, 1);
java.util.Calendar utcCalendar =
java.util.Calendar.getInstance(java.util.TimeZone.getTimeZone("UTC"));
pstmt.setTimestamp(2, originalTs, utcCalendar);
pstmt.executeUpdate();
System.out.println("Inserted timestamp with microsecond precision: " + originalTs);
ResultSet rs = stmt.executeQuery("SELECT id, ts FROM " + tableName + " WHERE id = 1");
if (rs.next()) {
java.sql.Timestamp retrievedTs = rs.getTimestamp(2);
System.out.println("Retrieved timestamp: " + retrievedTs);
System.out.println("Retrieved nanoseconds: " + retrievedTs.getNanos());
assertEquals(
185645000,
retrievedTs.getNanos(),
"Microsecond precision should be preserved (issue #1116 fix verification)");
System.out.println("✓ Microsecond precision preserved successfully!");
}
rs.close();
stmt.execute("DROP TABLE IF EXISTS " + tableName);
System.out.println("Cleaned up test table");
pstmt.close();
stmt.close();
} finally {
con.close();
System.out.println("Connection closed");
}
}
```
## Additional Notes to the Reviewer
<!-- Share any additional context or insights that may help the reviewer
understand the changes better. This could include challenges faced,
limitations, or compromises made during the development process.
Also, mention any areas of the code that you would like the reviewer to
focus on specifically. -->1 parent 58d731b commit dee4266
3 files changed
Lines changed: 172 additions & 5 deletions
File tree
- src
- main/java/com/databricks/jdbc/api/impl
- test/java/com/databricks/jdbc/api/impl
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
Lines changed: 17 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
449 | 461 | | |
450 | 462 | | |
451 | 463 | | |
| |||
Lines changed: 154 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
36 | 41 | | |
37 | 42 | | |
38 | 43 | | |
| |||
1209 | 1214 | | |
1210 | 1215 | | |
1211 | 1216 | | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
| 1220 | + | |
| 1221 | + | |
| 1222 | + | |
| 1223 | + | |
| 1224 | + | |
| 1225 | + | |
| 1226 | + | |
| 1227 | + | |
| 1228 | + | |
| 1229 | + | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
1212 | 1366 | | |
0 commit comments