Fix log argument formatting (#1098)

## Description
It appears that `JdbcLogger` expects SLF4J formatted strings (i.e. `{}`
rather than `%s`) given `JulLogger` already handles the reformatting of
strings via
[`slf4jToJavaFormat`](https://github.com/databricks/databricks-jdbc/blob/main/src/main/java/com/databricks/jdbc/log/JulLogger.java#L247).
Log strings containing `%s` are not currently being formatted correctly,
the `%s` appears in logs.

Co-authored-by: Thomas Powell <tpowell@palantir.com>

Author: tom-s-powell

src/main/java/com/databricks/jdbc/api/impl/DatabricksDatabaseMetaData.java

@@ -1503,8 +1503,9 @@ public RowIdLifetime getRowIdLifetime() throws SQLException {
   @Override
   public ResultSet getSchemas(String catalog, String schemaPattern) throws SQLException {
     LOGGER.debug(
-        "public ResultSet getSchemas(String catalog = %s, String schemaPattern = %s)",
-        catalog, schemaPattern);
+        "public ResultSet getSchemas(String catalog = {}, String schemaPattern = {})",
+        catalog,
+        schemaPattern);
     throwExceptionIfConnectionIsClosed();
 
     return session.getDatabricksMetadataClient().listSchemas(session, catalog, schemaPattern);

src/main/java/com/databricks/jdbc/api/impl/DatabricksStatement.java

@@ -546,7 +546,7 @@ public void handleResultSetClose(IDatabricksResultSet resultSet) throws Databric
 
   @Override
   public void setStatementId(StatementId statementId) {
-    LOGGER.debug("void setStatementId {%s}", statementId);
+    LOGGER.debug("void setStatementId(Statement statementId = {})", statementId);
     this.statementId = statementId;
   }
 

src/main/java/com/databricks/jdbc/api/impl/arrow/AbstractArrowResultChunk.java

@@ -227,8 +227,12 @@ protected void setStatus(ChunkStatus targetStatus) {
       stateMachine.transition(targetStatus);
     } catch (DatabricksParsingException e) {
       LOGGER.warn(
-          "Failed to transition to state [%s] from state [%s] for chunk [%d] and statement [%s]. Stack trace: %s",
-          targetStatus, getStatus(), chunkIndex, statementId, ExceptionUtils.getStackTrace(e));
+          "Failed to transition to state [{}] from state [{}] for chunk [{}] and statement [{}]. Stack trace: {}",
+          targetStatus,
+          getStatus(),
+          chunkIndex,
+          statementId,
+          ExceptionUtils.getStackTrace(e));
     }
   }
 
@@ -265,7 +269,7 @@ protected void waitForChunkReady()
     } catch (InterruptedException e) {
       LOGGER.error(
           e,
-          "Chunk download interrupted for chunk index %s and statement %s",
+          "Chunk download interrupted for chunk index {} and statement {}",
           chunkIndex,
           statementId);
       Thread.currentThread().interrupt();
@@ -283,11 +287,11 @@ protected void waitForChunkReady()
    */
   protected void initializeData(InputStream inputStream)
       throws DatabricksSQLException, IOException {
-    LOGGER.debug("Parsing data for chunk index %s and statement %s", chunkIndex, statementId);
+    LOGGER.debug("Parsing data for chunk index {} and statement {}", chunkIndex, statementId);
     ArrowData arrowData = getRecordBatchList(inputStream, rootAllocator, statementId, chunkIndex);
     recordBatchList = arrowData.getValueVectors();
     arrowMetadata = arrowData.getMetadata();
-    LOGGER.debug("Data parsed for chunk index %s and statement %s", chunkIndex, statementId);
+    LOGGER.debug("Data parsed for chunk index {} and statement {}", chunkIndex, statementId);
     setStatus(ChunkStatus.PROCESSING_SUCCEEDED);
   }
 
@@ -322,7 +326,7 @@ private ArrowData getRecordBatchList(
       // release resources if thread is interrupted when reading arrow data
       LOGGER.error(
           e,
-          "Data parsing interrupted for chunk index [%s] and statement [%s]. Error [%s]",
+          "Data parsing interrupted for chunk index [{}] and statement [{}]. Error [{}]",
           chunkIndex,
           statementId,
           e.getMessage());
@@ -365,8 +369,13 @@ private void logAllocatorStats(String event) {
     long initReservation = rootAllocator.getInitReservation();
 
     LOGGER.debug(
-        "Chunk allocator stats Log - Event: %s, Chunk Index: %s, Allocated Memory: %s, Peak Memory: %s, Headroom: %s, Init Reservation: %s",
-        event, chunkIndex, allocatedMemory, peakMemory, headRoom, initReservation);
+        "Chunk allocator stats Log - Event: {}, Chunk Index: {}, Allocated Memory: {}, Peak Memory: {}, Headroom: {}, Init Reservation: {}",
+        event,
+        chunkIndex,
+        allocatedMemory,
+        peakMemory,
+        headRoom,
+        initReservation);
   }
 
   /** Releases all Arrow-related resources and clears the record batch list. */

src/main/java/com/databricks/jdbc/api/impl/arrow/AbstractRemoteChunkProvider.java

@@ -283,8 +283,10 @@ private void populateChunkIndexMap(TRowSet resultData, ConcurrentMap<Long, T> ch
     rowCount += DatabricksThriftUtil.getRowCount(resultData);
     for (TSparkArrowResultLink resultLink : resultData.getResultLinks()) {
       LOGGER.debug(
-          "Chunk information log - Row Offset: %s, Row Count: %s, Expiry Time: %s",
-          resultLink.getStartRowOffset(), resultLink.getRowCount(), resultLink.getExpiryTime());
+          "Chunk information log - Row Offset: {}, Row Count: {}, Expiry Time: {}",
+          resultLink.getStartRowOffset(),
+          resultLink.getRowCount(),
+          resultLink.getExpiryTime());
       chunkIndexMap.put(chunkCount, createChunk(statementId, chunkCount, resultLink));
       chunkCount++;
     }

src/main/java/com/databricks/jdbc/api/impl/arrow/ArrowResultChunk.java

@@ -146,8 +146,9 @@ private void addHeaders(HttpGet getRequest, Map<String, String> headers) {
       headers.forEach(getRequest::addHeader);
     } else {
       LOGGER.debug(
-          "No encryption headers present for chunk index %s and statement %s",
-          chunkIndex, statementId);
+          "No encryption headers present for chunk index {} and statement {}",
+          chunkIndex,
+          statementId);
     }
   }
 

src/main/java/com/databricks/jdbc/api/impl/arrow/ChunkDownloadTask.java

@@ -107,8 +107,9 @@ public Void call() throws DatabricksSQLException, ExecutionException, Interrupte
         chunk.getChunkReadyFuture().complete(null); // complete the void future successfully
       } else {
         LOGGER.info(
-            "Uncaught exception during chunk download. Chunk index: %d, Error: %s",
-            chunk.getChunkIndex(), Arrays.toString(uncaughtException.getStackTrace()));
+            "Uncaught exception during chunk download. Chunk index: {}, Error: {}",
+            chunk.getChunkIndex(),
+            Arrays.toString(uncaughtException.getStackTrace()));
         // Status is set to DOWNLOAD_SUCCEEDED in the happy path. For any failure case,
         // explicitly set status to DOWNLOAD_FAILED here to ensure consistent error handling
         chunk.setStatus(ChunkStatus.DOWNLOAD_FAILED);

src/main/java/com/databricks/jdbc/api/impl/arrow/incubator/ArrowResultChunkV2.java

@@ -236,7 +236,7 @@ private void handleRetryableError(
     if (currentAttempt < retryConfig.maxAttempts) {
       long delayMs = calculateBackoffDelay(currentAttempt, retryConfig);
       LOGGER.warn(
-          "Retryable error during %s for chunk %s (attempt %s/%s), retrying in %s ms. Error: %s",
+          "Retryable error during {} for chunk {} (attempt {}/{}), retrying in {} ms. Error: {}",
           phase.getDescription(),
           chunkIndex,
           currentAttempt,

src/main/java/com/databricks/jdbc/api/impl/arrow/incubator/StreamingResponseConsumer.java

@@ -112,7 +112,10 @@ private void logDownloadStats() {
     double speedMBps = (chunk.bytesDownloaded / 1024.0 / 1024.0) / (durationMs / 1000.0);
 
     LOGGER.debug(
-        "Download stats for chunk %s: Size: %s MB, Duration: %s ms, Speed: %s MB/s",
-        chunk.getChunkIndex(), chunk.bytesDownloaded / 1024.0 / 1024.0, durationMs, speedMBps);
+        "Download stats for chunk {}: Size: {} MB, Duration: {} ms, Speed: {} MB/s",
+        chunk.getChunkIndex(),
+        chunk.bytesDownloaded / 1024.0 / 1024.0,
+        durationMs,
+        speedMBps);
   }
 }

src/main/java/com/databricks/jdbc/api/impl/volume/VolumeOperationProcessor.java

@@ -294,8 +294,9 @@ void executeGetOperation() {
     try (CloseableHttpResponse response = databricksHttpClient.execute(httpGet)) {
       if (!HttpUtil.isSuccessfulHttpResponse(response)) {
         LOGGER.error(
-            "Failed to fetch content from volume with error {%s} for local file {%s}",
-            response.getStatusLine().getStatusCode(), localFilePath);
+            "Failed to fetch content from volume with error {} for local file {}",
+            response.getStatusLine().getStatusCode(),
+            localFilePath);
         status = VolumeOperationStatus.FAILED;
         errorMessage = "Failed to download file";
         return;
@@ -367,8 +368,9 @@ void executePutOperation() {
         status = VolumeOperationStatus.SUCCEEDED;
       } else {
         LOGGER.error(
-            "Failed to upload file {%s} with error code: {%s}",
-            localFilePath, response.getStatusLine().getStatusCode());
+            "Failed to upload file {} with error code: {}",
+            localFilePath,
+            response.getStatusLine().getStatusCode());
         // TODO: Add retries
         status = VolumeOperationStatus.FAILED;
         errorMessage =
@@ -413,7 +415,7 @@ private void executeDeleteOperation() {
         status = VolumeOperationStatus.SUCCEEDED;
       } else {
         LOGGER.error(
-            "Failed to delete volume with error code: {%s}",
+            "Failed to delete volume with error code: {}",
             response.getStatusLine().getStatusCode());
         status = VolumeOperationStatus.FAILED;
         errorMessage = "Failed to delete volume";

src/main/java/com/databricks/jdbc/auth/EncryptedFileTokenCache.java

@@ -75,7 +75,7 @@ public void save(Token token) throws DatabricksException {
       file.setWritable(false, false);
       file.setWritable(true, true);
 
-      LOGGER.debug("Successfully saved encrypted token to cache: %s", cacheFile);
+      LOGGER.debug("Successfully saved encrypted token to cache: {}", cacheFile);
     } catch (Exception e) {
       throw new DatabricksException("Failed to save token cache: " + e.getMessage(), e);
     }
@@ -85,7 +85,7 @@ public void save(Token token) throws DatabricksException {
   public Token load() {
     try {
       if (!Files.exists(cacheFile)) {
-        LOGGER.debug("No token cache file found at: %s", cacheFile);
+        LOGGER.debug("No token cache file found at: {}", cacheFile);
         return null;
       }
 
@@ -96,19 +96,19 @@ public Token load() {
       try {
         decodedContent = decrypt(fileContent);
       } catch (Exception e) {
-        LOGGER.debug("Failed to decrypt token cache: %s", e.getMessage());
+        LOGGER.debug("Failed to decrypt token cache: {}", e.getMessage());
         return null;
       }
 
       // Deserialize token from JSON
       String json = new String(decodedContent, StandardCharsets.UTF_8);
       Token token = mapper.readValue(json, Token.class);
-      LOGGER.debug("Successfully loaded encrypted token from cache: %s", cacheFile);
+      LOGGER.debug("Successfully loaded encrypted token from cache: {}", cacheFile);
       return token;
     } catch (Exception e) {
       // If there's any issue loading the token, return null
       // to allow a fresh token to be obtained
-      LOGGER.debug("Failed to load token from cache: %s", e.getMessage());
+      LOGGER.debug("Failed to load token from cache: {}", e.getMessage());
       return null;
     }
   }