Fix main CI: JFrog mirror bypass and Windows pwsh parse error#1429
Closed
vikrantpuppala wants to merge 1 commit intomainfrom
Closed
Fix main CI: JFrog mirror bypass and Windows pwsh parse error#1429vikrantpuppala wants to merge 1 commit intomainfrom
vikrantpuppala wants to merge 1 commit intomainfrom
Conversation
Two CI workflows on main were failing: 1. runIntegrationTests.yml was caching ~/.m2, which restored a stale settings.xml on top of the JFrog-configured one written by the preceding Configure maven step. Maven then bypassed the mirror and tried to hit Maven Central directly, which the protected runner cannot reach. Narrow the cache path to ~/.m2/repository so settings.xml is preserved. 2. loggingTesting.yml's Get JFrog OIDC token and Configure maven steps used bash syntax (if [ ... ], heredoc) but had no shell directive. On Windows runners the default shell is pwsh, which fails to parse the bash if statement. Pin both steps to shell: bash. Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Collaborator
Author
|
Superseded — restoring #1428 with a follow-up commit to drop the bugCatcher hunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI workflows on
mainhave been failing. This PR fixes the root causes.1.
Integration Tests Workflow - Main Branch(failing 30+ runs in a row since Apr 8)path: ~/.m2with a long-lived restore-key${{ runner.os }}-m2. It restores a stale cache from before the JFrog OIDC migration, whose~/.m2/settings.xml(the github-server one written byactions/setup-java) overwrites the JFrog mirror config that the preceding "Configure maven" step just wrote.repo.maven.apache.orgdirectly, which the protected runner cannot reach:Could not transfer artifact ... from/to central (https://repo.maven.apache.org/maven2): Remote host terminated the handshake.pathto~/.m2/repositorysosettings.xmlis left alone (matches the pattern used bywarmMavenCache.yml).2.
Test JDBC Logging(Windows jobs failing since Apr 27)if [ -z "$X" ],set -euo pipefail) but has noshell:directive. On Windows runners the default shell ispwsh, which fails parsing the bashifwithMissing '(' after 'if'. The "Configure maven" step has the same problem (bash heredoc).shell: bash. Linux jobs were unaffected because their default shell is already bash.Test plan
Integration Tests Workflow - Main Branchpasses on the next push tomainTest JDBC LoggingWindows jobs pass on the next push tomainNO_CHANGELOG=true
OVERRIDE_FREEZE=true
This pull request and its description were written by Isaac.