Harden binary parameter interpolation against SQL injection#1497
Open
sreekanth-db wants to merge 1 commit into
Open
Harden binary parameter interpolation against SQL injection#1497sreekanth-db wants to merge 1 commit into
sreekanth-db wants to merge 1 commit into
Conversation
When client-side parameter interpolation is enabled, a value typed as BINARY is now spliced into the SQL unquoted only when it is a valid X'...' hex literal (as produced by setBytes); any other value is escaped as a string literal. Adds regression tests for the interpolator. Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens client-side parameter interpolation so a value typed as BINARY is spliced into the SQL unquoted only when it is a valid
X'...'hex literal (the form produced bysetBytes). Any other value is escaped as a string literal.Changes
SQLInterpolator: hex-literal allow-list for the BINARY branch; everything else is escaped.setBytes(X'...') behavior is unchanged.Testing
SQLInterpolatorTest,DatabricksPreparedStatementTest,DatabricksTypeUtilTest— all pass (168 tests).Full detail tracked privately in the associated security ticket.
This pull request and its description were written by Isaac.