Skip to content

Fix flaky test ChunkLinkDownloadServiceTest#testBatchDownloadChaining#811

Merged
jayantsing-db merged 1 commit into
mainfrom
jayantsing-db/fix-flaky-test
Apr 28, 2025
Merged

Fix flaky test ChunkLinkDownloadServiceTest#testBatchDownloadChaining#811
jayantsing-db merged 1 commit into
mainfrom
jayantsing-db/fix-flaky-test

Conversation

@jayantsing-db
Copy link
Copy Markdown
Collaborator

@jayantsing-db jayantsing-db commented Apr 25, 2025

Description

The link download futures were being completed because the link download chain was triggered eagerly. When getLinkForChunk is called, the link download future is evaluated. If the future is already complete, it checks the status of the chunk. The test was not mocking the chunk, which caused a NullPointerException (NPE). Locally, the test passed because the link download futures weren't completing before getLinkForChunk was called. However, in the GitHub runs, the futures were completing, which led to a thread synchronization issue.

NO_CHANGELOG=true

Testing

Additional Notes to the Reviewer

@github-actions
Copy link
Copy Markdown

Please ensure that the `NEXT_CHANGELOG.md` file is updated with any relevant changes.  
If this is not necessary for your PR, include this in the PR body:

```
NO_CHANGELOG=true
```

and rerun the workflow.

@jayantsing-db jayantsing-db merged commit 995a9d7 into databricks:main Apr 28, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants