Fix flaky test ChunkLinkDownloadServiceTest#testBatchDownloadChaining#811
Merged
Conversation
|
gopalldb
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The link download futures were being completed because the link download chain was triggered eagerly. When getLinkForChunk is called, the link download future is evaluated. If the future is already complete, it checks the status of the chunk. The test was not mocking the chunk, which caused a NullPointerException (NPE). Locally, the test passed because the link download futures weren't completing before getLinkForChunk was called. However, in the GitHub runs, the futures were completing, which led to a thread synchronization issue.
Testing
Additional Notes to the Reviewer