[PECOBLR-388] added real, numeric, char and bigint support in setObject method#818
Merged
Conversation
gopalldb
reviewed
May 7, 2025
| case DatabricksTypeUtil.INT: | ||
| return ColumnInfoTypeName.INT; | ||
| case DatabricksTypeUtil.BIGINT: | ||
| case DatabricksTypeUtil.LONG: |
Collaborator
There was a problem hiding this comment.
can we add for REAL also?
Collaborator
Author
There was a problem hiding this comment.
This is not needed, because we first convert java.Sql.Types into DatabricksType and then into columnInfoType. So, real is already converted to float in getDatabricksTypeFromSQLType, which is passed to getColumnInfoType.
gopalldb
approved these changes
May 12, 2025
Collaborator
Author
|
will add integration tests in a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for REAL, NUMERIC, CHAR and BIGINT data types in PreparedStatement.setObject() method.
setObject(int parameterIndex, Object x, int targetSqlType)allows users to insert values of specific type in queries.Testing
Unit test
manual test
script:
Additional Notes to the Reviewer