Skip to content

[PECOBLR-388] added real, numeric, char and bigint support in setObject method #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivam2680 merged 3 commits into from
May 12, 2025
Merged

[PECOBLR-388] added real, numeric, char and bigint support in setObject method #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a58699c
added real, numeric, char and long support in setObject method
shivam2680 May 7, 2025
0f7672d
updated nextchangelog.md
shivam2680 May 7, 2025
4b7ae16
added comments
shivam2680 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
-

### Fixed
-
- Fix: unsupported data types in `setObject(int,Object,int targetSqlType)` method in PreparedStatement

---
*Note: When making changes, please add your change under the appropriate section with a brief description.*
12 changes: 10 additions & 2 deletions src/main/java/com/databricks/jdbc/common/util/DatabricksTypeUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ public class DatabricksTypeUtil {
public static final String ARRAY = "ARRAY";
public static final String STRUCT = "STRUCT";
public static final String VARIANT = "VARIANT";
public static final String CHAR = "CHAR";
private static final ArrayList<ColumnInfoTypeName> SIGNED_TYPES =
new ArrayList<>(
Arrays.asList(
Expand All @@ -63,10 +64,12 @@ public class DatabricksTypeUtil {
ColumnInfoTypeName.LONG,
ColumnInfoTypeName.SHORT));

// only used for PreparedStatement
public static ColumnInfoTypeName getColumnInfoType(String typeName) {
switch (typeName) {
case DatabricksTypeUtil.CHAR:
case DatabricksTypeUtil.STRING:
return ColumnInfoTypeName.STRING;
return ColumnInfoTypeName.STRING; // both char, string passed as STRING param
case DatabricksTypeUtil.DATE:
case DatabricksTypeUtil.TIMESTAMP:
case DatabricksTypeUtil.TIMESTAMP_NTZ:
Expand All @@ -79,6 +82,7 @@ public static ColumnInfoTypeName getColumnInfoType(String typeName) {
case DatabricksTypeUtil.INT:
return ColumnInfoTypeName.INT;
case DatabricksTypeUtil.BIGINT:
case DatabricksTypeUtil.LONG:

@gopalldb gopalldb May 7, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add for REAL also?

@shivam2680 shivam2680 May 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, because we first convert java.Sql.Types into DatabricksType and then into columnInfoType. So, real is already converted to float in getDatabricksTypeFromSQLType, which is passed to getColumnInfoType.

return ColumnInfoTypeName.LONG;
case DatabricksTypeUtil.FLOAT:
return ColumnInfoTypeName.FLOAT;
Expand Down Expand Up @@ -359,6 +363,8 @@ public static Nullable getNullableFromValue(Integer isNullable) {
*/
public static String getDatabricksTypeFromSQLType(int sqlType) {
switch (sqlType) {
case Types.CHAR:
return DatabricksTypeUtil.CHAR;
case Types.ARRAY:
return ARRAY;
case Types.BIGINT:
Expand All @@ -370,13 +376,15 @@ public static String getDatabricksTypeFromSQLType(int sqlType) {
case Types.DATE:
return DATE;
case Types.DECIMAL:
return DECIMAL;
case Types.NUMERIC:
return DECIMAL; // Databricks treats NUMERIC as DECIMAL
case Types.BIT:
case Types.BOOLEAN:
return BOOLEAN;
case Types.DOUBLE:
return DOUBLE;
case Types.FLOAT:
case Types.REAL: // REAL is float(24)
return FLOAT;
case Types.INTEGER:
return INT;
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/com/databricks/jdbc/common/util/DatabricksTypeUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ void testGetDatabricksTypeFromSQLType() {
DatabricksTypeUtil.INT, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.INTEGER));
assertEquals(
DatabricksTypeUtil.STRING, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.VARCHAR));
assertEquals(
DatabricksTypeUtil.CHAR, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.CHAR));
assertEquals(
DatabricksTypeUtil.STRING,
DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.LONGVARCHAR));
Expand All @@ -178,6 +180,8 @@ void testGetDatabricksTypeFromSQLType() {
assertEquals(
DatabricksTypeUtil.BINARY,
DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.LONGVARBINARY));
assertEquals(
DatabricksTypeUtil.DECIMAL, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.NUMERIC));
assertEquals(
DatabricksTypeUtil.DATE, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.DATE));
assertEquals(
Expand All @@ -188,6 +192,8 @@ void testGetDatabricksTypeFromSQLType() {
DatabricksTypeUtil.DOUBLE, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.DOUBLE));
assertEquals(
DatabricksTypeUtil.FLOAT, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.FLOAT));
assertEquals(
DatabricksTypeUtil.FLOAT, DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.REAL));
assertEquals(
DatabricksTypeUtil.TIMESTAMP_NTZ,
DatabricksTypeUtil.getDatabricksTypeFromSQLType(Types.TIMESTAMP));
Expand Down Expand Up @@ -234,6 +240,7 @@ void testInferDatabricksType() {
"BYTE, BYTE",
"INT, INT",
"BIGINT, LONG",
"LONG, LONG",
"FLOAT, FLOAT",
"DOUBLE, DOUBLE",
"BINARY, BINARY",
Expand All @@ -244,6 +251,7 @@ void testInferDatabricksType() {
"VOID, NULL",
"NULL, NULL",
"MAP, MAP",
"CHAR, STRING",
"UNKNOWN, USER_DEFINED_TYPE"
})
public void testGetColumnInfoType(String inputTypeName, String expectedTypeName) {
Expand Down
Loading