[PECOBLR-399] Added connection params to DatabricksDriverPropertyUtil#822
Merged
Conversation
saishreeeee
changed the title
Collaborator
|
Congrats on your first PR 🚢 |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
shivam2680
reviewed
May 26, 2025
shivam2680
left a comment
shivam2680
left a comment
Collaborator
There was a problem hiding this comment.
Can you please add logic for ALLOW_SELF_SIGNED_CERTS, SSL_TRUST_STORE and related properties in buildMissingPropertiesList logic as well.
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
saishreeeee
requested review from
shivam2680 and
vikrantpuppala
and removed request for
vikrantpuppala
shivam2680
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the connection params to DatabricksDriverPropertyUtil
Testing
Additional Notes to the Reviewer
NO_CHANGELOG=true