-
Notifications
You must be signed in to change notification settings - Fork 40
[PECOBLR-421] Add explicit null check for empty values in an Arrow value vector #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+89
−0
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
688cf75
Add support for configuring HTTP connection pool size
gopalldb 2e6bfaa
Changes for default value
gopalldb 8ee0fa1
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 5f7d0c1
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 2e28c9e
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb a720802
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb e88657b
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 2670e43
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb c4925ee
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 5a5f1de
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb bf41453
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb b81f4ad
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 1e790a4
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 5ed0c08
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 73029b4
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb ffc2aae
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 7cf9cc8
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb f55ca04
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb ceb2fcb
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 77552fc
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 0690dea
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 638a11a
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 5da3b1e
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 8dbee51
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 5c72ef9
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb b769422
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 860a7ff
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb 3a3e1e4
Add null check in arrow value conversion
gopalldb 57b6abb
fix comments
gopalldb eb1fa9b
add changelog
gopalldb 4589902
more tests
gopalldb aac5322
Merge branch 'main' of github.com:databricks/databricks-jdbc
gopalldb c2187d2
Merge branch 'main' into null-arrow
gopalldb d5b2945
merge
gopalldb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are not actually testing any change in behaviour in our class, can we instead do
verifycalls to ensure the appropriate methods are being called when the value vector is null?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not simulating iceberg library usage. Need to find a better test case for that. Will handle in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test now.