[PECOBLR-427] Add INTERVAL Type support#835
Merged
Merged
Conversation
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
shivam2680
requested review from
deeksha-db,
gopalldb,
jayantsing-db,
madhav-db and
samikshya-db
shivam2680
changed the title
gopalldb
reviewed
May 23, 2025
| timeZone = Optional.of(((TimeStampMicroTZVector) columnVector).getTimeZone()); | ||
| } | ||
| return convertToTimestamp(object, timeZone); | ||
| case INTERVAL: |
Collaborator
There was a problem hiding this comment.
we don't need to handle in json?
Collaborator
Author
There was a problem hiding this comment.
there's no json type in ColumnInfoTypeName
Collaborator
There was a problem hiding this comment.
Let's add a TODO and revisit this before SEA default rollout
Collaborator
Author
There was a problem hiding this comment.
added todo and created tracking ticket
https://databricks.atlassian.net/browse/PECOBLR-442
gopalldb
reviewed
May 23, 2025
gopalldb
reviewed
May 23, 2025
| private static final JdbcLogger LOGGER = JdbcLoggerFactory.getLogger(IntervalConverter.class); | ||
|
|
||
| // Arrow stores day‐time intervals in microseconds | ||
| private static final long MICROS_PER_SECOND = 1_000_000L; |
Collaborator
There was a problem hiding this comment.
where are you using this?
Collaborator
Author
There was a problem hiding this comment.
removed unused constants
gopalldb
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add INTERVAL data type support to OSS JDBC. Enables users to query on interval type columns on databricks. Supported in all execution modes.
SEA inline output will differ from others as the Conversion logic is as per JSON_ARRAY format instead of HIVE.
Legacy driver as well as thrift follows HIVE, so going with that.
Testing
Additional Notes to the Reviewer