fix for registration conflicts with BouncyCastleProvider#864
Merged
sreekanth-db merged 5 commits intoJul 4, 2025
Conversation
📊 Code Coverage Report
|
451743a to
283e1d4
Compare
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
8ec3bea to
1e64c46
Compare
Collaborator
|
2 comments :
|
samikshya-db
approved these changes
Jul 4, 2025
Co-authored-by: Samikshya Chand <148681192+samikshya-db@users.noreply.github.com>
Collaborator
Author
|
There is some issue with the coverage comparison workflow, will fix it in a subsequent pull request. Coverage percentage from local jacoco report for this branch is 86.31% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The core problem is from the static registration of the BouncyCastle Security Provider in Java's Security API. When multiple BouncyCastle library versions are on the classpath, each trying to register its "BC" provider, conflicts occur. This can arise from different versions being introduced by drivers, the application, or its dependencies. The first registered provider wins, leading to unpredictable behavior if an older or incompatible version is registered before the expected one. This causes difficult-to-diagnose runtime problems for customers, highlighting the need to isolate or control BouncyCastle registration.
Solution: We will no longer globally register BouncyCastleProvider in Java's security API. Instead, our driver will create a dedicated local BouncyCastleProvider instance for it usage.
Testing
Tested jwt flow in local
Additional Notes to the Reviewer