Adds SSLTrustStoreProvider support to Databricks JDBC#875
Merged
Conversation
📊 Code Coverage Report
|
- Added support for SSL client certificate authentication via the new parameter: SSLTrustStoreProvider. - Introduced a test case for SSL trust store parameters to validate default settings in the DatabricksConnectionContext. Signed-off-by: [Your Name] <your.email@databricks.com>
…ontextTest - Introduced a new test case to validate the handling of SSL trust store parameters, including SSLTrustStore, SSLTrustStorePwd, SSLTrustStoreType, and SSLTrustStoreProvider. Signed-off-by: [Your Name] <your.email@databricks.com>
gopalldb
reviewed
Jul 2, 2025
gopalldb
reviewed
Jul 2, 2025
| LOGGER.error(errorMessage); | ||
| StringBuilder errorMessage = | ||
| new StringBuilder() | ||
| .append("Failed to load trust store: ") |
Collaborator
There was a problem hiding this comment.
You can use String.format here, e.g. String.format("bla bla bla %s bla %s", value1, value2);
gopalldb
approved these changes
Jul 7, 2025
vikrantpuppala
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds SSLTrustStoreProvider support to Databricks JDBC
Testing
Unit test
Additional Notes to the Reviewer