[PECOBLR-762] Make U2M work independent to that of java sdk#954
Merged
samikshya-db merged 8 commits intoSep 4, 2025
Conversation
samikshya-db
changed the title
| } | ||
|
|
||
| @Override | ||
| public String authType() { |
Collaborator
There was a problem hiding this comment.
nit; move this to static constant.
| } | ||
|
|
||
| if (tokenResponse.has("expires_in")) { | ||
| int expiresIn = tokenResponse.get("expires_in").asInt(); |
Collaborator
There was a problem hiding this comment.
Usually time fields are casted in long and not int. It is within contracts?
Collaborator
Author
There was a problem hiding this comment.
I see that a mature sdk like Okta also has it in int (Link)
I guess we should be ok with this for now.
| callbackServer.start(callbackPort); | ||
| try { | ||
| // Give the server a moment to be fully ready | ||
| Thread.sleep(200); |
Collaborator
There was a problem hiding this comment.
Where is this 200ms number coming from?
Collaborator
|
LGTM overall but |
Collaborator
Author
|
[C1] Thanks for reviewing, @nikhilsuri-db. |
nikhilsuri-db
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional Notes to the Reviewer