Added optional EnableSQLValidationForIsValid property for isValid() to allow users to enable server-side SQL validation#961
Merged
Conversation
shivam2680
reviewed
Aug 26, 2025
| stmt.setQueryTimeout(timeout); | ||
| stmt.execute("SELECT VERSION()"); | ||
| return true; | ||
| } catch (SQLException e) { |
Collaborator
There was a problem hiding this comment.
how are we distinguishing client/server side exceptions
Collaborator
Author
There was a problem hiding this comment.
We're returning false for all exceptions.
…o allow users to enable server-side SQL validation
…_VALIDATION_FOR_IS_VALID
msrathore-db
force-pushed
the
PECOBLR-772
branch
from
8de1894 to
9d37fda
Compare
gopalldb
reviewed
Aug 26, 2025
…S_VALID from client info properties
gopalldb
approved these changes
Aug 29, 2025
… used after it is added to the proto file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added SQL execution based isValid check gated by a connection property EnableSQLValidationForIsValid. This allows users to enable server-side SQL validation of isValid(). The validation is based on the execution of SELECT VERSION() query for optimised latency.
This is an optional property. The default behaviour is not changed for isValid()
Testing
Tested manually using a large query to check if the timeout functions well.
RELATED TICKETS AND DOCUMENTS
PECOBLR-772
ES-1361851