-
Notifications
You must be signed in to change notification settings - Fork 40
Added optional EnableSQLValidationForIsValid property for isValid() to allow users to enable server-side SQL validation #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f53d29c
Added optional EnableSQLValidationForIsValid property for isValid() t…
msrathore-db eb683b9
Changed property ENABLE_SQL_VALIDATION_FOR_ISVALID name to ENABLE_SQL…
msrathore-db b95a0ed
Updated NEXT_CHANGELOG
msrathore-db d43283a
Added a get method for EnableSQLValidation
msrathore-db e4e4141
Updated validation query to SELECT CURRENT_TIMESTAMP for better latency
msrathore-db ff3c031
Updated validation query to SELECT VERSION() for optimised latency
msrathore-db 1641117
Added comments and updated changelog
msrathore-db 5fbbc50
Updated the get method for enable SQL validation to return a boolean
msrathore-db 9d37fda
Query bug fix
msrathore-db 471ce41
Added unit test for isValid() and removed ENABLE_SQL_VALIDATION_FOR_I…
msrathore-db 626749e
Added enableSQLValidationForIsValid in the telemetry
msrathore-db 182a50b
Commented the telemetry code for EnableSQLValidationForIsValid. To be…
msrathore-db b5d9040
Removed the comments for telemetry support for EnableSQLValidation fo…
msrathore-db 5c78367
Updated NEXT_CHANGELOG.md
msrathore-db dfaa8e1
Resolved merge conflict
msrathore-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.