[Bugfix] Fix backward incompatible change in SDK : browser auth flow#973
Merged
samikshya-db merged 1 commit intoSep 2, 2025
Conversation
samikshya-db
changed the title
shivam2680
approved these changes
Sep 1, 2025
| .setHost(host) | ||
| .setClientId(clientId) | ||
| .setOAuthBrowserAuthTimeout( | ||
| Duration.ofHours(1)) // TODO : add a browser timeout connection config |
Collaborator
There was a problem hiding this comment.
- what was the previous default?
- can we remove the todo? since this is a user interactive flow, i don't think we ever need this to be configurable?
Collaborator
Author
There was a problem hiding this comment.
- It used to wait indefinitely for user interaction, which can cause applications to hang indefinitely if
users don't complete the authentication process. - This is a feature ask because of legacy driver parity. Doc : https://docs.google.com/document/d/17wkI_I16_k6Igl0QPDWZkgbg-7VApebyO4D1yVeXfpM/edit?tab=t.0#heading=h.ig8zh4bt1u8z
Collaborator
Author
There was a problem hiding this comment.
Also added this in the PR description for more context. Thanks
vikrantpuppala
approved these changes
Sep 2, 2025
| .setHost(host) | ||
| .setClientId(clientId) | ||
| .setOAuthBrowserAuthTimeout( | ||
| Duration.ofHours(1)) // TODO : add a browser timeout connection config |
samikshya-db
deleted the
samikshya-chand_data/backwardIncompatibleChange
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional Notes to the Reviewer
NO_CHANGELOG=true