[PECOBLR-747] Thin jar#987
Merged
Merged
Conversation
| <dependency> | ||
| <groupId>com.databricks</groupId> | ||
| <artifactId>databricks-jdbc-thin</artifactId> | ||
| <version>1.0.9-oss</version> |
Collaborator
There was a problem hiding this comment.
This won't be present in this version, can we add a comment on this? (Customer might get confused by this )
Collaborator
Author
There was a problem hiding this comment.
added comment that it will be available after 1.10.0 release
Comment on lines
+39
to
54
| - name: Publish Thin JAR as Separate Artifact | ||
| run: | | ||
| # Sign and deploy thin JAR with full dependency metadata | ||
| # Uses GPG signing to ensure artifact integrity | ||
| VERSION=$(grep -m1 '<version>' pom.xml | sed 's/.*<version>\(.*\)<\/version>.*/\1/') | ||
| mvn -Prelease gpg:sign-and-deploy-file \ | ||
| -Dfile="target/databricks-jdbc-${VERSION}-thin.jar" \ | ||
| -DpomFile=thin_public_pom.xml \ | ||
| -DrepositoryId=central \ | ||
| -DgroupId=com.databricks \ | ||
| -DartifactId=databricks-jdbc-thin \ | ||
| -Dversion="${VERSION}" \ | ||
| -Dpackaging=jar \ | ||
| -DgeneratePom=false \ | ||
| -Dgpg.passphrase="${GPG_PASSPHRASE}" | ||
| env: |
Collaborator
There was a problem hiding this comment.
This is not required, this is already taken care in the below patch where we say :
files: target/*.jar
Collaborator
Author
There was a problem hiding this comment.
this is for github release artifacts and not maven release artifacts
samikshya-db
approved these changes
Sep 10, 2025
Collaborator
samikshya-db
left a comment
samikshya-db
left a comment
There was a problem hiding this comment.
I have some comments, please merge after that. Thanks for making the changes 🫙
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customer reported that the Databricks thin JAR "specifies no dependencies at all" in its POM, preventing dependency introspection tools from working. Users cannot:
Solution:
Deploy the existing thin JAR as a separate artifact (databricks-jdbc-thin) with a POM that declares all runtime dependencies:
Testing
Additional Notes to the Reviewer