Skip to content

Commit 1d7cd36

Browse files
committed
adjust according to feedback
1 parent 3921dd8 commit 1d7cd36

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

NEXT_CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
* Added `NewLimitIterator` to `listing` package for lazy iteration with a cap on output items ([#1555](https://github.com/databricks/databricks-sdk-go/pull/1555)).
1313

1414
### Bug Fixes
15-
fix: 1243 returns both resetErr and the request's err on retries.Halt
1615

16+
* Fixed request error being discarded when the request body cannot be reset for retry ([#1363](https://github.com/databricks/databricks-sdk-go/pull/1363)).
1717
* Fix double-caching of OAuth tokens in Azure client secret credentials ([#1549](https://github.com/databricks/databricks-sdk-go/issues/1549)).
1818
* Disable async token refresh for GCP credential providers to avoid wasted refresh attempts caused by double-caching with Google's internal `oauth2.ReuseTokenSource` ([#1549](https://github.com/databricks/databricks-sdk-go/issues/1549)).
1919
* Fixed double-caching in M2M OAuth that prevented the proactive async token refresh from reaching the HTTP endpoint until ~10s before expiry, causing bursts of 401 errors at token rotation boundaries ([#1549](https://github.com/databricks/databricks-sdk-go/issues/1549)).

httpclient/api_client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ func (c *ApiClient) handleError(ctx context.Context, err error, body common.Requ
260260
}
261261
if resetErr := body.Reset(); resetErr != nil {
262262
return nil, retries.Halt(
263-
fmt.Errorf("%w, request error: %w", resetErr, err),
263+
fmt.Errorf("%w (unable to reset request body for retry: %w)", err, resetErr),
264264
)
265265
}
266266
return nil, retries.Continue(err)

0 commit comments

Comments
 (0)