Fixes

Author: hectorcast-db

common/types/duration/duration.go

@@ -12,7 +12,7 @@ import (
 //
 // It embeds time.Duration, so all standard methods (Seconds, String, etc.)
 // are directly accessible. The underlying time.Duration value can be
-// accessed via the .Duration field.
+// accessed via the .AsDuration() method.
 //
 // Example:
 //
@@ -35,12 +35,6 @@ func (x *Duration) AsDuration() time.Duration {
 	return x.Duration
 }
 
-// NewDuration creates a custom Duration from a standard time.Duration.
-// Deprecated: Use New instead.
-func NewDuration(d time.Duration) Duration {
-	return Duration{Duration: d}
-}
-
 // MarshalJSON implements the json.Marshaler interface by formatting the
 // duration as a string according to Google Well Known Type
 func (d Duration) MarshalJSON() ([]byte, error) {
@@ -53,8 +47,8 @@ func (d Duration) MarshalJSON() ([]byte, error) {
 // the number of seconds, with nanoseconds expressed as fractional seconds.
 // https://protobuf.dev/reference/protobuf/google.protobuf/#duration
 func (d Duration) ToWireFormat() string {
-	// We do not use the standard time.Duration.String() method because it
-	// loses precision when converting to a string.
+	// We do not use the standard time.Duration.String() and d.Duration.Seconds()
+	// method because they use float64 which loses precision.
 
 	// Get the total nanoseconds as a precise integer.
 	nanos := d.Duration.Nanoseconds()

common/types/fieldmask/fieldmask_test.go

@@ -107,18 +107,6 @@ func TestFieldMask_UnmarshalJSON(t *testing.T) {
 			want:    FieldMask{Paths: []string{"name", "age", ""}},
 			wantErr: false,
 		},
-		{
-			name:    "leading comma",
-			input:   `",name,age"`,
-			want:    FieldMask{Paths: []string{"", "name", "age"}},
-			wantErr: false,
-		},
-		{
-			name:    "consecutive commas",
-			input:   `"name,,age"`,
-			want:    FieldMask{Paths: []string{"name", "", "age"}},
-			wantErr: false,
-		},
 		{
 			name:    "invalid JSON",
 			input:   `invalid`,

common/types/time/time.go

@@ -7,12 +7,12 @@ import (
 	stdtime "time"
 )
 
-// Time is a wrapper for stdtime.Time to provide custom marshaling
+// Time is a wrapper for time.Time to provide custom marshaling
 // for JSON and URL query strings.
 //
-// It embeds stdtime.Time, so all standard methods (Format, Parse, etc.)
-// are directly accessible. The underlying stdtime.Time value can be
-// accessed via the .Time field.
+// It embeds time.Time, so all standard methods (Format, Parse, etc.)
+// are directly accessible. The underlying time.Time value can be
+// accessed via the .AsTime() method.
 //
 // Example:
 //

common/types/time/time_test.go

@@ -256,69 +256,44 @@ func TestTime_JSONRoundTrip(t *testing.T) {
 }
 
 func TestTime_EdgeCases(t *testing.T) {
-	t.Run("very old time", func(t *testing.T) {
-		oldTime := stdtime.Date(1000, 1, 1, 0, 0, 0, 0, stdtime.UTC)
-		timeVal := *New(oldTime)
-
-		jsonData, err := json.Marshal(timeVal)
-		if err != nil {
-			t.Errorf("json.Marshal() error = %v", err)
-			return
-		}
-
-		var result Time
-		err = json.Unmarshal(jsonData, &result)
-		if err != nil {
-			t.Errorf("json.Unmarshal() error = %v", err)
-			return
-		}
-
-		if !result.Time.Equal(oldTime) {
-			t.Errorf("Time round trip failed: original = %v, result = %v", oldTime, result)
-		}
-	})
-
-	t.Run("very future time", func(t *testing.T) {
-		futureTime := stdtime.Date(9999, 12, 31, 23, 59, 59, 999999999, stdtime.UTC)
-		timeVal := *New(futureTime)
-
-		jsonData, err := json.Marshal(timeVal)
-		if err != nil {
-			t.Errorf("json.Marshal() error = %v", err)
-			return
-		}
-
-		var result Time
-		err = json.Unmarshal(jsonData, &result)
-		if err != nil {
-			t.Errorf("json.Unmarshal() error = %v", err)
-			return
-		}
-
-		if !result.Time.Equal(futureTime) {
-			t.Errorf("Time round trip failed: original = %v, result = %v", futureTime, result)
-		}
-	})
+	tests := []struct {
+		name string
+		time stdtime.Time
+	}{
+		{
+			name: "very old time",
+			time: stdtime.Date(1000, 1, 1, 0, 0, 0, 0, stdtime.UTC),
+		},
+		{
+			name: "very future time",
+			time: stdtime.Date(9999, 12, 31, 23, 59, 59, 999999999, stdtime.UTC),
+		},
+		{
+			name: "leap year time",
+			time: stdtime.Date(2024, 2, 29, 12, 0, 0, 0, stdtime.UTC),
+		},
+	}
 
-	t.Run("leap year time", func(t *testing.T) {
-		leapTime := stdtime.Date(2024, 2, 29, 12, 0, 0, 0, stdtime.UTC)
-		timeVal := *New(leapTime)
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			timeVal := *New(tt.time)
 
-		jsonData, err := json.Marshal(timeVal)
-		if err != nil {
-			t.Errorf("json.Marshal() error = %v", err)
-			return
-		}
+			jsonData, err := json.Marshal(timeVal)
+			if err != nil {
+				t.Errorf("json.Marshal() error = %v", err)
+				return
+			}
 
-		var result Time
-		err = json.Unmarshal(jsonData, &result)
-		if err != nil {
-			t.Errorf("json.Unmarshal() error = %v", err)
-			return
-		}
+			var result Time
+			err = json.Unmarshal(jsonData, &result)
+			if err != nil {
+				t.Errorf("json.Unmarshal() error = %v", err)
+				return
+			}
 
-		if !result.Time.Equal(leapTime) {
-			t.Errorf("Time round trip failed: original = %v, result = %v", leapTime, result)
-		}
-	})
+			if !result.Time.Equal(tt.time) {
+				t.Errorf("Time round trip failed: original = %v, result = %v", tt.time, result)
+			}
+		})
+	}
 }