Commit 8d0c6e0
authored
[Internal] Remove resolved host metadata from HostType() method (#1630)
## Changes
Removing this to unblock the Terraform provider release followed by the
Go SDK bump.
Partially reverts #1606 — removes the `resolvedHostType` early-return in
`HostType()` and the associated tests.
Specifically:
- Removes the `if c.resolvedHostType != HostTypeUnknown { return
c.resolvedHostType }` block from `HostType()`
- Removes the `// When host metadata has been resolved...` comment that
described the reverted behavior
- Keeps the `// Deprecated:` comment on `HostType()`
- Removes 7 test cases that validated the metadata-first behavior
(`TestHostType_UsesMetadataFirst_*`,
`TestHostType_FallsBackToURLWhenMetadataUnknown*`,
`TestHostType_MetadataOverridesExperimentalFlag`,
`TestHostType_EndToEnd_MetadataResolvesHostType`)
- Removes the changelog entry for this change
`HostType()` now returns to its pre-#1606 behavior: URL-pattern-only
detection, which is what downstream consumers (TF provider) still rely
on.
NO_CHANGELOG=true
## Tests
Existing `config` package tests pass (`go test ./config/...`). The
removed tests were specific to the reverted behavior.
Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>1 parent 44ebcb4 commit 8d0c6e0
3 files changed
Lines changed: 0 additions & 78 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | 450 | | |
454 | 451 | | |
455 | 452 | | |
456 | 453 | | |
457 | 454 | | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | 455 | | |
464 | 456 | | |
465 | 457 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | 89 | | |
159 | 90 | | |
160 | 91 | | |
| |||
0 commit comments