Remove usage of testify in persistent_auth_test.go.#1238
Merged
Conversation
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
approved these changes
Jun 26, 2025
Comment on lines
-25
to
-27
| if m.store == nil { | ||
| panic("no store mock") | ||
| } |
Contributor
There was a problem hiding this comment.
Just for my understanding, why are we removing this?
Contributor
Author
There was a problem hiding this comment.
The extra code has very little value. If the test was broken, we would still receive a panic due to the nil pointer exception which will have a very clear root cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR removes usage of
testifyinpersistent_auth_test. The change is not focused on improving the test ergonomy but rather in cutting the dependency ontestifyin preparation to another PR.How is this tested?
N/A
NO_CHANGELOG=true