Skip to content

[DO NOT MERGE] Well Known Types tests#1244

Closed
hectorcast-db wants to merge 6 commits into
mainfrom
hectorcast-db/well-known-preview-2
Closed

[DO NOT MERGE] Well Known Types tests#1244
hectorcast-db wants to merge 6 commits into
mainfrom
hectorcast-db/well-known-preview-2

Conversation

@hectorcast-db

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

Provide the readers and reviewers with the information they need to understand
this PR in a comprehensive manner.

Specifically, try to answer the two following questions:

  • WHAT changes are being made in the PR? This should be a summary of the
    major changes to allow the reader to quickly understand the PR without having
    to look at the code.
  • WHY are these changes needed? This should provide the context that the
    reader might be missing. For example, were there any decisions behind the
    change that are not reflected in the code itself?

The “why part” is the most important of the two as it usually cannot be
inferred from the code itself. A well-written PR description will help future
developers (including your future self) to know how to interact and update your
code.

How is this tested?

Describe any tests you have done; especially if test tests are not part of
the unit tests (e.g. local tests).

ALWAYS ANSWER THIS QUESTION: Answer with "N/A" if tests are not applicable
to your PR (e.g. if the PR only modifies comments). Do not be afraid of
answering "Not tested" if the PR has not been tested. Being clear about what
has been done and not done provides important context to the reviewers.

@github-actions

github-actions Bot commented Jul 4, 2025

Copy link
Copy Markdown

Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes.
If this is not necessary for your PR, please include the following in your PR description:
NO_CHANGELOG=true
and rerun the job.

},
ForceSendFields: []string{"FilterBy"},
}
pb, err := listClustersRequestToPb(&r)

@hectorcast-db hectorcast-db Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query.Values only checks the interface for the fields of the object passed, not the object itself.

This means that the top level entity must have the url annotation in the fields for the name to be correct.

This is already like this in the create methods (we pass the PB struct). Replicating this in this test.

@hectorcast-db hectorcast-db force-pushed the hectorcast-db/well-known-preview-2 branch from 88df874 to 4e7634c Compare July 4, 2025 09:15
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/well-known-preview-2 branch from 4e7634c to 4f670c0 Compare July 4, 2025 09:18
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/well-known-preview-2 branch from c92dba6 to e28d3fc Compare July 4, 2025 12:48
@github-actions

github-actions Bot commented Jul 4, 2025

Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1244
  • Commit SHA: e28d3fc17aaade586dd5a126b7aa48a9e10969d8

Checks will be approved automatically on success.

@hectorcast-db hectorcast-db changed the title [DO NOT MERGE] Well Known TYpes tests [DO NOT MERGE] Well Known Types tests Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant