Skip to content

TEST DO NOT MERGE#1251

Closed
tanmay-db wants to merge 2 commits into
mainfrom
testing-network-policy-changes
Closed

TEST DO NOT MERGE#1251
tanmay-db wants to merge 2 commits into
mainfrom
testing-network-policy-changes

Conversation

@tanmay-db

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

Provide the readers and reviewers with the information they need to understand
this PR in a comprehensive manner.

Specifically, try to answer the two following questions:

  • WHAT changes are being made in the PR? This should be a summary of the
    major changes to allow the reader to quickly understand the PR without having
    to look at the code.
  • WHY are these changes needed? This should provide the context that the
    reader might be missing. For example, were there any decisions behind the
    change that are not reflected in the code itself?

The “why part” is the most important of the two as it usually cannot be
inferred from the code itself. A well-written PR description will help future
developers (including your future self) to know how to interact and update your
code.

How is this tested?

Describe any tests you have done; especially if test tests are not part of
the unit tests (e.g. local tests).

ALWAYS ANSWER THIS QUESTION: Answer with "N/A" if tests are not applicable
to your PR (e.g. if the PR only modifies comments). Do not be afraid of
answering "Not tested" if the PR has not been tested. Being clear about what
has been done and not done provides important context to the reviewers.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is July 21, 2025 20:59 — with GitHub Actions Inactive
Comment thread service/settings/model.go
// The associated account ID for this Network Policy object.
AccountId string `json:"account_id,omitempty"`
// The network policies applying for egress traffic.
Egress *NetworkPolicyEgress `json:"egress,omitempty"`

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlight

@tanmay-db tanmay-db temporarily deployed to test-trigger-is July 21, 2025 21:00 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown

Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes.
If this is not necessary for your PR, please include the following in your PR description:
NO_CHANGELOG=true
and rerun the job.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is July 22, 2025 14:10 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is July 22, 2025 14:11 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1251
  • Commit SHA: 2ebe9bc20edfc9422a86f3b8e423b300b11bb999

Checks will be approved automatically on success.

@tanmay-db tanmay-db closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant