Add new ErrHTMLContent value to represent errors due to HTML parsing.#1252
Merged
Conversation
parthban-db
reviewed
Jul 22, 2025
parthban-db
left a comment
parthban-db
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo clarification.
Comment on lines
+372
to
+374
| statusCode: 200, | ||
| status: "OK", | ||
| errorMessage: httpclient.ErrHTMLContent.Error(), |
Contributor
There was a problem hiding this comment.
For my understanding, is this case even possible? Don't we have a single statuscode for this kind of error?
parthban-db
approved these changes
Jul 22, 2025
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds a new error value
ErrHTMLContentto differentiate parsing errors caused by HTML content from other parsing errors — which are likely to be due actual implementation issues within the SDK. The new error value can be used by higher-level tools (e.g. the Databricks CLI) to provide actionable feedback to users.How is this tested?
Unit and integration tests.