Skip to content

Increase burst for rate limiter #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 6 commits into from
Sep 17, 2025
Merged

Increase burst for rate limiter #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df995ca
Increase burst for rate limiter
denik Sep 10, 2025
6e78bb1
set to 5
denik Sep 10, 2025
386ec91
Remove the cap
denik Sep 10, 2025
6d1f085
add NEXT_CHANGELOG.md
denik Sep 17, 2025
c6313db
add a comment
denik Sep 17, 2025
3b7960d
use cfg.RateLimitPerSecond; remove default
denik Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Release v0.84.0

### New Features and Improvements
* Increased rate limiter burst setting from 1 to rate\_limit value.

### Bug Fixes

Expand Down
5 changes: 3 additions & 2 deletions httpclient/api_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,18 @@ func NewApiClient(cfg ClientConfig) *ApiClient {
cfg.ErrorRetriable = DefaultErrorRetriable
}
transport := cfg.httpTransport()
rateLimit := rate.Limit(orDefault(cfg.RateLimitPerSecond, 15))
rateLimit := rate.Limit(cfg.RateLimitPerSecond)
// depend on the HTTP fixture interface to prevent any coupling
if skippable, ok := transport.(interface {
SkipRetryOnIO() bool
}); ok && skippable.SkipRetryOnIO() {
rateLimit = rate.Inf
cfg.RetryTimeout = 0
}

return &ApiClient{
config: cfg,
rateLimiter: rate.NewLimiter(rateLimit, 1),
rateLimiter: rate.NewLimiter(rateLimit, cfg.RateLimitPerSecond),
httpClient: &http.Client{
// We deal with request timeouts ourselves such that we do not
// time out during request or response body reads that make
Expand Down
Loading