From ad7e582ad355aa9e6b63241b0469e2860ab7a699 Mon Sep 17 00:00:00 2001 From: Denis Bilenko Date: Wed, 17 Sep 2025 11:53:52 +0200 Subject: [PATCH 1/2] Set default HTTPTimeout to 60s As far as I can see the intention is to have 60s (README.md says 60s). The code sets both 30s and 60s but 30s is set first so it takes priority as the default. --- httpclient/api_client.go | 1 - 1 file changed, 1 deletion(-) diff --git a/httpclient/api_client.go b/httpclient/api_client.go index d54fd3fb3..038271096 100644 --- a/httpclient/api_client.go +++ b/httpclient/api_client.go @@ -106,7 +106,6 @@ func (cfg ClientConfig) httpTransport() http.RoundTripper { func NewApiClient(cfg ClientConfig) *ApiClient { // Set defaults for config values that are not set. - cfg.HTTPTimeout = time.Duration(orDefault(int(cfg.HTTPTimeout), int(30*time.Second))) cfg.DebugTruncateBytes = orDefault(cfg.DebugTruncateBytes, 96) cfg.RetryTimeout = time.Duration(orDefault(int(cfg.RetryTimeout), int(5*time.Minute))) cfg.HTTPTimeout = time.Duration(orDefault(int(cfg.HTTPTimeout), int(60*time.Second))) From ba16e3137e3118118c2ef2274296530583dcc902 Mon Sep 17 00:00:00 2001 From: Denis Bilenko Date: Wed, 17 Sep 2025 11:57:56 +0200 Subject: [PATCH 2/2] add NEXT_CHANGELOG --- NEXT_CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEXT_CHANGELOG.md b/NEXT_CHANGELOG.md index 10a8c5ba2..9c044f107 100644 --- a/NEXT_CHANGELOG.md +++ b/NEXT_CHANGELOG.md @@ -5,6 +5,7 @@ ### New Features and Improvements ### Bug Fixes +- Set default HTTPTimeout to 60s to match documented one. ### Documentation