Upload of big files (> 5Gb) to UC Volumes using multipart chunking#1621
Open
alexott wants to merge 9 commits into
Open
Upload of big files (> 5Gb) to UC Volumes using multipart chunking#1621alexott wants to merge 9 commits into
alexott wants to merge 9 commits into
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. Thank you for your contributions. |
github-actions
Bot
added
the
stale
…tipart upload Signed-off-by: Alex Ott <alexey.ott@databricks.com>
…rts, complete) Co-authored-by: Isaac Signed-off-by: Alex Ott <alexey.ott@databricks.com>
…FromFile Signed-off-by: Alex Ott <alexey.ott@databricks.com>
Best-effort abort of incomplete multipart uploads when a part upload fails, preventing orphaned upload sessions on the server. Signed-off-by: Alex Ott <alexey.ott@databricks.com>
Signed-off-by: Alex Ott <alexey.ott@databricks.com>
- Fix URL expiration retry to fetch fresh presigned URLs instead of retrying the same expired URL - Remove total http.Client timeout that would kill large part uploads; rely on context cancellation instead - Add context cancellation checks in the main upload loop - Extract partUploadError type for structured error handling Signed-off-by: Alex Ott <alexey.ott@databricks.com>
…est coverage Address review feedback: expose upload methods via FilesInterface, fall back to single-shot upload when the first multipart chunk fails, validate contentLength matches actual bytes read, and add tests for all new paths. Co-authored-by: Isaac
Signed-off-by: Alex Ott <alexey.ott@databricks.com>
alexott
changed the title
alexott
force-pushed
the
feature/multipart-chunked-upload
branch
from
05dc9ac to
cdbdc26
Compare
Contributor
Author
|
@chrisst - that would be useful for TF integration |
github-actions
Bot
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. Thank you for your contributions. |
github-actions
Bot
added
the
stale
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement upload of big files (> 5Gb) to UC Volumes using multipart chunking. That functionality already exists in Python SDK, but is missing in the Go SDK.
It will require some modifications in the codegen to support new functionality
Why
databricks/terraform-provider-databricks#5521 is asking for support of big files, but Go SDK doesn't have this functionality
What changed
Interface changes
New functions are added to Files interface (requires codegen changes)
Behavioral changes
Internal changes
How is this tested?
Unit tests were added