Commit b27860a
authored
Fix Paginator dropping results on empty token pages (#818)
## Summary
Fix `Paginator` silently dropping results when a token-paginated
response returns an empty page that still carries a `next_page_token`.
Adds explicit `newTokenPagination` / `newOffsetPagination` factories and
regenerates all list methods to use them. Backward compatible — the
existing constructor is kept and deprecated.
## Why
Token-paginated endpoints (e.g. `tables().list()`) may return empty
intermediate pages with a valid `next_page_token` — the only reliable
end-of-results signal is the token's absence. `Paginator` stopped at the
first empty page, so these calls under-returned results. Offset/limit
APIs (SCIM, legacy SQL) have no token and *do* end on an empty page, so
the fix is strategy-aware (a blanket "skip empty pages" would loop those
forever).
## What changed
- `Paginator.newTokenPagination(...)` — page until `nextPageFn` returns
null; empty pages are skipped.
- `Paginator.newOffsetPagination(...)` — stop on the first empty page
(previous behavior).
- The existing `Paginator` constructor is **kept and `@Deprecated`**,
retaining its prior offset/limit behavior — no breaking change.
- Regenerated `*API.java` (91 token / 34 offset). Hand-written:
`SharesExtAPI` → token; SCIM `Users`/`Groups`/`ServicePrincipals` +
`Account*` → offset.
## How is this tested?
- `PaginatorTest`: token pagination walks past empty
leading/intermediate pages; offset pagination still stops on the first
empty page.
- `mvn clean compile` over the full regenerated SDK (3,902 sources)
passes.
Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>1 parent 6c3ad50 commit b27860a
125 files changed
Lines changed: 374 additions & 180 deletions
File tree
- databricks-sdk-java/src
- main/java/com/databricks/sdk
- service
- apps
- billing
- bundle
- catalog
- cleanrooms
- compute
- dashboards
- database
- dataquality
- disasterrecovery
- environments
- files
- iam
- jobs
- knowledgeassistants
- marketplace
- ml
- networking
- oauth2
- pipelines
- postgres
- qualitymonitorv2
- serving
- settingsv2
- settings
- sharing
- sql
- supervisoragents
- tags
- vectorsearch
- workspace
- support
- test/java/com/databricks/sdk/support
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| 13 | + | |
| 14 | + | |
11 | 15 | | |
12 | 16 | | |
13 | 17 | | |
| |||
Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments