Commit 51de41f
authored
Use __file__-relative paths for test fixtures (#1445)
## Summary
Two tests hardcode relative paths (`tests/testdata/...` and
`databricks/__init__.py`) that only resolve when pytest's cwd is the SDK
root. Switch them to `pathlib.Path(__file__)`-based paths so they work
no matter where pytest is launched.
## Why
Today's upstream invocation (`make test` from the SDK root) is the happy
case, so it goes unnoticed. But pytest from any other directory — a
different CWD, a CI runner that builds the source tree elsewhere, or a
Bazel test sandbox — fails the tests with `FileNotFoundError`.
## What changed
### Interface changes
None.
### Behavioral changes
None (same fixture files, just resolved by absolute path).
### Internal changes
- `tests/test_model_serving_auth.py`:
`\"tests/testdata/model-serving-test-token\"` and `\"...-v2\"`
parameters replaced with constants computed from
`pathlib.Path(__file__).parent / \"testdata\"`.
- `tests/test_init_file.py`: `open(\"databricks/__init__.py\")` replaced
with `open(pathlib.Path(__file__).parent.parent / \"databricks\" /
\"__init__.py\")`.
## How is this tested?
- `make test` from the SDK root: 2073 passed, 3 skipped, same baseline
as main.
- `pytest tests/test_model_serving_auth.py tests/test_init_file.py` from
outside the SDK root (e.g. `/tmp`): now passes (previously fails with
`FileNotFoundError`).
NO_CHANGELOG=true1 parent 1047d7b commit 51de41f
2 files changed
Lines changed: 21 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
2 | 7 | | |
3 | 8 | | |
4 | 9 | | |
| |||
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
10 | | - | |
| 15 | + | |
11 | 16 | | |
12 | 17 | | |
13 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
11 | 18 | | |
12 | 19 | | |
13 | 20 | | |
| |||
24 | 31 | | |
25 | 32 | | |
26 | 33 | | |
27 | | - | |
| 34 | + | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
33 | 40 | | |
34 | 41 | | |
35 | | - | |
| 42 | + | |
36 | 43 | | |
37 | 44 | | |
38 | 45 | | |
39 | 46 | | |
40 | 47 | | |
41 | 48 | | |
42 | 49 | | |
43 | | - | |
| 50 | + | |
44 | 51 | | |
45 | 52 | | |
46 | 53 | | |
47 | 54 | | |
48 | 55 | | |
49 | 56 | | |
50 | 57 | | |
51 | | - | |
| 58 | + | |
52 | 59 | | |
53 | 60 | | |
54 | 61 | | |
| |||
92 | 99 | | |
93 | 100 | | |
94 | 101 | | |
95 | | - | |
| 102 | + | |
96 | 103 | | |
97 | 104 | | |
98 | 105 | | |
| |||
122 | 129 | | |
123 | 130 | | |
124 | 131 | | |
125 | | - | |
| 132 | + | |
126 | 133 | | |
127 | 134 | | |
128 | 135 | | |
| |||
136 | 143 | | |
137 | 144 | | |
138 | 145 | | |
139 | | - | |
| 146 | + | |
140 | 147 | | |
141 | 148 | | |
142 | 149 | | |
| |||
172 | 179 | | |
173 | 180 | | |
174 | 181 | | |
175 | | - | |
| 182 | + | |
176 | 183 | | |
177 | 184 | | |
178 | 185 | | |
| |||
0 commit comments