adding thumbs up, thumbs down, comments and review request for GenieAPI in the SDK#1002
Closed
pavel-chowdhury-maersk wants to merge 7 commits into
Closed
Conversation
TODO add annotation and custom response class
Signed-off-by: pavel-chowdhury-maersk <pavel.chowdhury@maersk.com>
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
|
Thanks for reaching out. Unfortunately, we cannot accept this PR. Our SDKs are automatically generated based on the configuration provided by different teams. This means that even if we merge this, the change will be undone automatically the next time we release the SDK. We will be redirecting the request to add this method to the appropriate team. I will close this PR since it cannot be merged, but feel free to ask follow-up questions if any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
WHAT: This PR adds Genie API functionality to the Databricks SDK, specifically implementing support for feedback and review features that come out of the box with Genie. The changes include:
GenieAPIclass to enable interaction with Databricks Genie feedback and review mechanismsubmit_message_feedback) supporting both thumbs up/down ratingssubmit_comment) for collaborative reviewupdate_message_review_request)FeedbackRatingenum for standardized feedback ratingsWHY: At Maersk, we are integrating Genie with Microsoft Teams to leverage all the built-in features for feedback and review workflows. The existing Databricks SDK lacked direct support for Genie's collaborative features, which are essential for our MS Teams-based analytics and review processes. This integration enables programmatic interaction with Genie feedback and review system, allowing us to build automated feedback collection and review workflows.
Feedback Requested
I would greatly appreciate feedback on this PR to ensure it adheres to Databricks contribution guidelines and standards. As this is my first contribution to the Databricks SDK, I want to make sure the implementation follows:
Any suggestions for improvements or alignment with established practices would be very valuable.
How is this tested?
The Genie API integration has been tested using the following code snippet in a live Genie space:
Testing Status: Tested locally against live Genie space with successful feedback submission, comment creation, and review request updates. All API endpoints responded correctly and the feedback/comments appeared in the Genie interface as expected.
Note for Testing: To test this integration, replace the placeholder values (
your-workspace.azuredatabricks.net,your-access-token-here,your-space-id-here, etc.) with actual values from your Databricks workspace and Genie space.