Add headers to HttpRequestResponse in OpenAI client.#1006
Merged
renaudhartert-db merged 1 commit intoJul 21, 2025
Conversation
fa1f84d to
83aa2f0
Compare
83aa2f0 to
2589662
Compare
2589662 to
fbbdcd2
Compare
fbbdcd2 to
9cb1b62
Compare
9cb1b62 to
baffa43
Compare
Comment on lines
+97
to
+110
| res = self._api.do( | ||
| "POST", | ||
| "/api/2.0/external-function", | ||
| body={ | ||
| "connection_name": conn, | ||
| "method": method.value, | ||
| "path": path, | ||
| "headers": js.dumps(headers) if headers is not None else None, | ||
| "json": js.dumps(json) if json is not None else None, | ||
| "params": js.dumps(params) if params is not None else None, | ||
| }, | ||
| headers={"Accept": "text/plain", "Content-Type": "application/json"}, | ||
| raw=True, | ||
| response_headers=headers_to_capture, |
Contributor
There was a problem hiding this comment.
@hectorcast-db, can you think of something better given the current libraries? Not using the underlying API method is really not ideal but I can't think of a better alternative with the code that we have right now.
baffa43 to
5df6134
Compare
renaudhartert-db
approved these changes
Jul 21, 2025
auto-merge was automatically disabled
July 21, 2025 16:07
Head branch was pushed to by a user without write access
7e516fe to
b7c44e3
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adding headers to HttpRequestResponse when making http_request
Why?
Basically we need the response headers that is used in the MCP spec: https://modelcontextprotocol.io/specification/2025-06-18/basic/transports#session-management
Specially Mcp-Session-Id header.
How is this tested?