Skip to content

Fix FilesExt should fallback when Presigned URL is not available#1093

Merged
yuanjieding-db merged 1 commit into
mainfrom
yuanjie/fix-presigned-url-unavailable
Oct 30, 2025
Merged

Fix FilesExt should fallback when Presigned URL is not available#1093
yuanjieding-db merged 1 commit into
mainfrom
yuanjie/fix-presigned-url-unavailable

Conversation

@yuanjieding-db

Copy link
Copy Markdown
Collaborator

What changes are proposed in this pull request?

Provide the readers and reviewers with the information they need to understand
this PR in a comprehensive manner.

Specifically, try to answer the two following questions:

  • WHAT
    • Fix FilesExt's upload and download should fallback when Presigned URLs are not available in certain compute types.
  • WHY
    • In some newer compute clusters (e.g. model serving clusters), creating presigned URL through Files API is not possible yet. Client should fallback in such circumstances to not using Presigned URL. Or else the customer wouldn't be able to upload or download data using w.files.

How is this tested?

It is tested using unit tests.

@yuanjieding-db yuanjieding-db force-pushed the yuanjie/fix-presigned-url-unavailable branch from 8ff911c to 3e41991 Compare October 30, 2025 13:14
@github-actions

Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 1093
  • Commit SHA: 3e419918e73209e4de23138ad5607eb557488d33

Checks will be approved automatically on success.

@yuanjieding-db yuanjieding-db added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit b4ffd99 Oct 30, 2025
17 checks passed
@yuanjieding-db yuanjieding-db deleted the yuanjie/fix-presigned-url-unavailable branch October 30, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants