Skip to content

Remove timeout from poll method and LroOptions.#1104

Merged
parthban-db merged 2 commits into
mainfrom
parthban-db/stack/change-none-timeout
Nov 7, 2025
Merged

Remove timeout from poll method and LroOptions.#1104
parthban-db merged 2 commits into
mainfrom
parthban-db/stack/change-none-timeout

Conversation

@parthban-db

@parthban-db parthban-db commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

Remove timeout from poll method and LroOptions. This is one of the PRs that removes the timeout from the LRO operation.

How is this tested?

Existing CI.

NO_CHANGELOG=true

@tejaskochar-db tejaskochar-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

"""
Args:
timeout: The timeout for the Long Running Operations.
If not set, the default timeout is 20 minutes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update this instead with what happens when a timeout is not provided?
Eg: If not set, then operations do not time out.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

@parthban-db parthban-db force-pushed the parthban-db/stack/change-none-timeout branch from 1f96682 to ae5b4a3 Compare November 6, 2025 13:05
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 1104
  • Commit SHA: ae5b4a31a94a64f8787a9f0579bcf5ab0f74bedb

Checks will be approved automatically on success.

@parthban-db parthban-db enabled auto-merge November 6, 2025 13:14
@parthban-db parthban-db added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit c365716 Nov 7, 2025
17 checks passed
@parthban-db parthban-db deleted the parthban-db/stack/change-none-timeout branch November 7, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants