Skip to content

Add sync-label check: PRs need the maintainer-applied 'sync' label#1473

Merged
hectorcast-db merged 2 commits into
mainfrom
hectorcastejon/sync-label-check
Jun 12, 2026
Merged

Add sync-label check: PRs need the maintainer-applied 'sync' label#1473
hectorcast-db merged 2 commits into
mainfrom
hectorcastejon/sync-label-check

Conversation

@hectorcast-db

Copy link
Copy Markdown
Contributor

What

A required-check candidate that fails unless the PR carries the sync label. The label needs triage+ permission, so external contributors can't self-apply it — and maintainers must perform one deliberate act before a PR becomes mergeable, which is exactly the accidental-merge failure mode this guards against. Replaces the old [sync]-in-title convention (titles are author-controlled, i.e. spoofable).

The error message routes non-sync PRs to CONTRIBUTING.md's mirror flow.

Temporary: goes away once release automation owns merging.

Try it

This PR itself is the test: the sync-label check should be failing right now. Applying the sync label should turn it green (the labeled event re-runs it); removing the label flips it back.

Follow-ups (not this PR)

  • Add sync-label to the required status checks in the repo ruleset (eng-dev-ecosystem) so it actually blocks.
  • Sync the workflow file into the Universe subtree so the next release sync doesn't delete it.

This pull request and its description were written by Isaac.

This repo is a read-only mirror of the internal source of truth; the
only PRs that should merge are release syncs. The check fails unless
the PR carries the 'sync' label (triage+ permission to apply), so a
merge always requires a deliberate maintainer act. Temporary until
release automation takes over merging.

Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>
@hectorcast-db hectorcast-db added the sync Release sync PR from the internal source of truth — required for merge label Jun 12, 2026
@Divyansh-db Divyansh-db added sync Release sync PR from the internal source of truth — required for merge and removed sync Release sync PR from the internal source of truth — required for merge labels Jun 12, 2026
@hectorcast-db hectorcast-db added this pull request to the merge queue Jun 12, 2026
@hectorcast-db hectorcast-db removed this pull request from the merge queue due to a manual request Jun 12, 2026
The label gate runs at PR level (required checks must pass to enter
the merge queue). Without a merge_group trigger, a required
sync-label check would never report on queue groups and stall every
entry.

Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>
@github-actions

Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 1473
  • Commit SHA: b7da97ea898d30f9bfba0327cd10815a7bccb30f

Checks will be approved automatically on success.

@hectorcast-db hectorcast-db enabled auto-merge June 12, 2026 08:44
@hectorcast-db hectorcast-db added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 4314a9b Jun 12, 2026
14 checks passed
@hectorcast-db hectorcast-db deleted the hectorcastejon/sync-label-check branch June 12, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync Release sync PR from the internal source of truth — required for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants