Add sync-label check: PRs need the maintainer-applied 'sync' label#1473
Merged
Conversation
This repo is a read-only mirror of the internal source of truth; the only PRs that should merge are release syncs. The check fails unless the PR carries the 'sync' label (triage+ permission to apply), so a merge always requires a deliberate maintainer act. Temporary until release automation takes over merging. Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>
Divyansh-db
approved these changes
Jun 12, 2026
The label gate runs at PR level (required checks must pass to enter the merge queue). Without a merge_group trigger, a required sync-label check would never report on queue groups and stall every entry. Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A required-check candidate that fails unless the PR carries the
synclabel. The label needs triage+ permission, so external contributors can't self-apply it — and maintainers must perform one deliberate act before a PR becomes mergeable, which is exactly the accidental-merge failure mode this guards against. Replaces the old[sync]-in-title convention (titles are author-controlled, i.e. spoofable).The error message routes non-sync PRs to CONTRIBUTING.md's mirror flow.
Temporary: goes away once release automation owns merging.
Try it
This PR itself is the test: the
sync-labelcheck should be failing right now. Applying thesynclabel should turn it green (thelabeledevent re-runs it); removing the label flips it back.Follow-ups (not this PR)
sync-labelto the required status checks in the repo ruleset (eng-dev-ecosystem) so it actually blocks.This pull request and its description were written by Isaac.