Remove ForceEnableTelemetry; unify under client > server > default priority

ForceEnableTelemetry was redundant with the opt-in priority logic introduced
in PR #319: setting EnableTelemetry=true (client) already takes precedence
over server feature flags, so a separate bypass flag was unnecessary.

- Remove ForceEnableTelemetry from UserConfig, DeepCopy, and DSN parsing
- Simplify connector.go telemetry init to check only EnableTelemetry
- Update DESIGN.md to reflect the unified priority model

Author: samikshya-db

connector.go

@@ -76,14 +76,12 @@ func (c *connector) Connect(ctx context.Context) (driver.Conn, error) {
 	}
 	log := logger.WithContext(conn.id, driverctx.CorrelationIdFromContext(ctx), "")
 
-	// Initialize telemetry (always attempt, let feature flags decide)
+	// Initialize telemetry: pass user opt-in flag; if unset, feature flags decide
 	var enableTelemetry *bool
-	if c.cfg.ForceEnableTelemetry || c.cfg.EnableTelemetry {
-		// User explicitly enabled telemetry
+	if c.cfg.EnableTelemetry {
 		trueVal := true
 		enableTelemetry = &trueVal
 	}
-	// else: leave nil to check server feature flag
 
 	conn.telemetry = telemetry.InitializeForConnection(
 		ctx,

internal/config/config.go

@@ -99,8 +99,7 @@ type UserConfig struct {
 	RetryWaitMax   time.Duration
 	RetryMax       int
 	// Telemetry configuration
-	EnableTelemetry          bool // Opt-in for telemetry (respects server feature flags)
-	ForceEnableTelemetry     bool // Force enable telemetry (bypasses server checks)
+	EnableTelemetry bool // Opt-in for telemetry; follows client > server > default priority
 	Transport                http.RoundTripper
 	UseLz4Compression        bool
 	EnableMetricViewMetadata bool
@@ -148,7 +147,6 @@ func (ucfg UserConfig) DeepCopy() UserConfig {
 		EnableMetricViewMetadata: ucfg.EnableMetricViewMetadata,
 		CloudFetchConfig:         ucfg.CloudFetchConfig,
 		EnableTelemetry:          ucfg.EnableTelemetry,
-		ForceEnableTelemetry:     ucfg.ForceEnableTelemetry,
 	}
 }
 
@@ -295,13 +293,6 @@ func ParseDSN(dsn string) (UserConfig, error) {
 		ucfg.EnableTelemetry = enableTelemetry
 	}
 
-	if forceEnableTelemetry, ok, err := params.extractAsBool("forceEnableTelemetry"); ok {
-		if err != nil {
-			return UserConfig{}, err
-		}
-		ucfg.ForceEnableTelemetry = forceEnableTelemetry
-	}
-
 	// for timezone we do a case insensitive key match.
 	// We use getNoCase because we want to leave timezone in the params so that it will also
 	// be used as a session param.

telemetry/DESIGN.md

@@ -1440,12 +1440,9 @@ type Config struct {
 	// Enabled controls whether telemetry is active
 	Enabled bool
 
-	// ForceEnableTelemetry bypasses server-side feature flag checks
-	// When true, telemetry is always enabled regardless of server flags
-	ForceEnableTelemetry bool
-
-	// EnableTelemetry indicates user wants telemetry enabled if server allows
-	// Respects server-side feature flags and rollout percentage
+	// EnableTelemetry indicates user wants telemetry enabled.
+	// Follows client > server > default priority: if set by the client it takes
+	// precedence; otherwise the server feature flag and defaults are consulted.
 	EnableTelemetry bool
 
 	// BatchSize is the number of metrics to batch before flushing
@@ -1474,9 +1471,8 @@ type Config struct {
 // Note: Telemetry is disabled by default and requires explicit opt-in.
 func DefaultConfig() *Config {
 	return &Config{
-		Enabled:              false, // Disabled by default, requires explicit opt-in
-		ForceEnableTelemetry: false,
-		EnableTelemetry:      false,
+		Enabled:         false, // Disabled by default, requires explicit opt-in
+		EnableTelemetry: false,
 		BatchSize:            100,
 		FlushInterval:           5 * time.Second,
 		MaxRetries:              3,
@@ -1495,14 +1491,7 @@ func DefaultConfig() *Config {
 func ParseTelemetryConfig(params map[string]string) *Config {
 	cfg := DefaultConfig()
 
-	// Check for forceEnableTelemetry flag (bypasses server feature flags)
-	if v, ok := params["forceEnableTelemetry"]; ok {
-		if v == "true" || v == "1" {
-			cfg.ForceEnableTelemetry = true
-		}
-	}
-
-	// Check for enableTelemetry flag (respects server feature flags)
+	// Check for enableTelemetry flag (follows client > server > default priority)
 	if v, ok := params["enableTelemetry"]; ok {
 		if v == "true" || v == "1" {
 			cfg.EnableTelemetry = true
@@ -2108,17 +2097,15 @@ func BenchmarkInterceptor_Disabled(b *testing.B) {
 
 ### Phase 5: Opt-In Configuration Integration ✅ COMPLETED
 - [x] Implement `isTelemetryEnabled()` with priority-based logic in config.go
-  - [x] Priority 1: ForceEnableTelemetry=true bypasses all checks → return true
-  - [x] Priority 2: EnableTelemetry=false explicit opt-out → return false
-  - [x] Priority 3: EnableTelemetry=true + check server feature flag
-  - [x] Priority 4: Server-side feature flag only (default behavior)
-  - [x] Priority 5: Default disabled if no flags set and server check fails
+  - [x] Priority 1 (client): EnableTelemetry=true → enable regardless of server flag
+  - [x] Priority 2 (client): EnableTelemetry=false → disable regardless of server flag
+  - [x] Priority 3 (server): Server feature flag controls when client preference unset
+  - [x] Priority 4 (default): Disabled if no flags set and server check fails
 - [x] Integrate feature flag cache with opt-in logic
   - [x] Wire up isTelemetryEnabled() to call featureFlagCache.isTelemetryEnabled()
   - [x] Implement fallback behavior on errors (return cached value or false)
   - [x] Add proper error handling
 - [x] Add unit tests for opt-in priority logic
-  - [x] Test forceEnableTelemetry=true (always enabled, bypasses server)
   - [x] Test enableTelemetry=false (always disabled, explicit opt-out)
   - [x] Test enableTelemetry=true with server flag enabled
   - [x] Test enableTelemetry=true with server flag disabled
@@ -2165,7 +2152,7 @@ func BenchmarkInterceptor_Disabled(b *testing.B) {
   - [x] Increment feature flag cache reference count
   - [x] Store telemetry interceptor in connection
 - [x] Add telemetry configuration to UserConfig
-  - [x] EnableTelemetry and ForceEnableTelemetry fields
+  - [x] EnableTelemetry field (client > server > default priority)
   - [x] DSN parameter parsing
   - [x] DeepCopy support
 - [x] Add cleanup in `Close()` methods