Commit 746974e
committed
Address PR review comment: Track CloseOperation errors in telemetry
This addresses @vikrantpuppala's review comment:
"if the CloseOperation call fails below, that error is logged but never
reflected in telemetry so we're missing capturing some errors in telemetry"
Changes:
- Added closeOpErr variable to capture CloseOperation failures
- Include CloseOperation errors in telemetry's deferred function
- Provides observability for resource cleanup issues
- Operation still returns success to caller (cleanup is best-effort)
Note: The timing fix ("shouldn't this be before runQuery?") will be addressed
in the follow-up PR once BeforeExecuteWithTime infrastructure is available.1 parent 4e38383 commit 746974e
1 file changed
+6
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| |||
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
140 | 145 | | |
141 | 146 | | |
142 | 147 | | |
| |||
152 | 157 | | |
153 | 158 | | |
154 | 159 | | |
| 160 | + | |
155 | 161 | | |
156 | 162 | | |
157 | 163 | | |
| |||
0 commit comments