Commit 851ea14
committed
Regenerate cli_service.go from thrift instead of hand-editing
Address review feedback: the prior commit added EnforceEmbeddedSchemaCorrectness
to internal/cli_service/cli_service.go by hand. Regenerate via the thrift
compiler (0.19.0) by adding the field to TCLIService.thrift
(0xD19: optional bool enforceEmbeddedSchemaCorrectness = false) and running
`thrift -r --gen go TCLIService.thrift`.
Because the thrift definition has a default value, the generated field is
`bool` (value) rather than `*bool` (pointer). Update connection.go to assign
the value directly.
Co-authored-by: Isaac1 parent f3d1048 commit 851ea14
2 files changed
Lines changed: 9 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
323 | 323 | | |
324 | 324 | | |
325 | 325 | | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
| 326 | + | |
330 | 327 | | |
331 | 328 | | |
332 | 329 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments