Commit b31339e
authored
[SIRT-1753] Bump go-jose/go-jose/v3 to v3.0.5 (CVE-2026-34986) (#360)
## Summary
Addresses [SIRT-1753](https://databricks.atlassian.net/browse/SIRT-1753)
by bumping the transitive `github.com/go-jose/go-jose/v3` dependency
from `v3.0.4` to `v3.0.5`, which patches **CVE-2026-34986** (JWE
`KeyUnwrap` panic → DoS).
- `go-jose` is an indirect dependency pulled in via `coreos/go-oidc/v3`.
- The vulnerable code path (`ParseEncrypted*` → `Decrypt`) is never
reached by this driver — `go-oidc` is used only for OIDC provider
discovery (fetching `.well-known/openid-configuration`).
- The bump is to satisfy SCA scanners; it is not a functional change.
## Scope note: CVE-2026-41602 (apache/thrift) is intentionally **not**
included
SIRT-1753 also flags `github.com/apache/thrift v0.17.0` for
**CVE-2026-41602** (TFramedTransport integer overflow). This PR does
**not** bump thrift, for two reasons:
1. **The upstream fix only lands in `apache/thrift v0.23.0`**, which
requires **Go 1.25**. This module's `go.mod` is pinned to `go 1.20`.
Bumping the go directive to 1.25 would force every downstream consumer
on Go 1.20–1.24 to upgrade their build toolchain — a breaking change
inappropriate for a security patch release.
2. **The vulnerable component is not reachable.** Per [Ricardo's
analysis on
SIRT-1753](https://databricks.atlassian.net/browse/SIRT-1753), the
driver only uses `THttpClient` (see `internal/client/client.go:283` and
the hardcoded `ThriftTransport: "http"` default in
`internal/config/config.go`). `TFramedTransport` is never instantiated —
there is no code path, even a fallback, that constructs it.
The non-exploitability of CVE-2026-41602 will be communicated back to
SIRT (VEX / suppression) rather than addressed via a toolchain bump. We
can revisit when the driver's Go floor moves as part of a planned,
communicated minor release.
## Test plan
- [x] `go build ./...` — clean
- [x] `go test ./...` — all packages pass
This pull request and its description were written by Isaac.
[SIRT-1753]:
https://databricks.atlassian.net/browse/SIRT-1753?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>1 parent dd8a79f commit b31339e
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
| 24 | + | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
0 commit comments