Fix golangci-lint failures

- exporter: remove unused telemetryPayload struct (deadcode)
- exporter, aggregator: restore logger.Trace in recover blocks (SA9003 empty branch)
- benchmark_test: add _ = to unchecked releaseClient calls (errcheck)
- integration_test: add _ = to unchecked json.Encode/Unmarshal calls (errcheck)

Co-authored-by: Isaac

Author: samikshya-db

telemetry/aggregator.go

@@ -65,8 +65,7 @@ func (agg *metricsAggregator) recordMetric(ctx context.Context, metric *telemetr
 	// Swallow all errors
 	defer func() {
 		if r := recover(); r != nil {
-			// Log at trace level only
-			// logger.Trace().Msgf("telemetry: recordMetric panic: %v", r)
+			logger.Trace().Msgf("telemetry: recordMetric panic: %v", r)
 		}
 	}()
 
@@ -141,7 +140,7 @@ func (agg *metricsAggregator) recordMetric(ctx context.Context, metric *telemetr
 func (agg *metricsAggregator) completeStatement(ctx context.Context, statementID string, failed bool) {
 	defer func() {
 		if r := recover(); r != nil {
-			// Log at trace level only
+			logger.Trace().Msgf("telemetry: completeStatement panic: %v", r)
 		}
 	}()
 
@@ -229,7 +228,7 @@ func (agg *metricsAggregator) flushUnlocked(ctx context.Context) {
 		defer func() {
 			<-agg.exportSem
 			if r := recover(); r != nil {
-				// Log at trace level only
+				logger.Trace().Msgf("telemetry: async export panic: %v", r)
 			}
 		}()
 		agg.exporter.export(ctx, metrics)

telemetry/benchmark_test.go

@@ -145,7 +145,7 @@ func BenchmarkConcurrentConnections_PerHostSharing(b *testing.B) {
 			_ = client
 
 			// Release client
-			mgr.releaseClient(host)
+			_ = mgr.releaseClient(host)
 		}
 	})
 }
@@ -212,7 +212,7 @@ func TestLoadTesting_ConcurrentConnections(t *testing.T) {
 			}
 
 			// Release client
-			mgr.releaseClient(host)
+			_ = mgr.releaseClient(host)
 		}()
 	}
 

telemetry/exporter.go

@@ -9,6 +9,8 @@ import (
 	"net/http"
 	"strings"
 	"time"
+
+	"github.com/databricks/databricks-sql-go/logger"
 )
 
 const (
@@ -39,11 +41,6 @@ type telemetryMetric struct {
 	tags        map[string]interface{}
 }
 
-// telemetryPayload is the JSON structure sent to Databricks.
-type telemetryPayload struct {
-	Metrics []*exportedMetric `json:"metrics"`
-}
-
 // exportedMetric is a single metric in the payload.
 type exportedMetric struct {
 	MetricType  string                 `json:"metric_type"`
@@ -81,8 +78,7 @@ func (e *telemetryExporter) export(ctx context.Context, metrics []*telemetryMetr
 	// Swallow all errors and panics
 	defer func() {
 		if r := recover(); r != nil {
-			// Log at trace level only
-			// logger.Trace().Msgf("telemetry: export panic: %v", r)
+			logger.Trace().Msgf("telemetry: export panic: %v", r)
 		}
 	}()
 
@@ -97,8 +93,7 @@ func (e *telemetryExporter) export(ctx context.Context, metrics []*telemetryMetr
 	}
 
 	if err != nil {
-		// Log at trace level only
-		// logger.Trace().Msgf("telemetry: export error: %v", err)
+		logger.Trace().Msgf("telemetry: export error: %v", err)
 	}
 }
 

telemetry/integration_test.go

@@ -167,7 +167,7 @@ func TestIntegration_OptInPriority_ExplicitOptOut(t *testing.T) {
 				"databricks.partnerplatform.clientConfigsFeatureFlags.enableTelemetryForGoDriver": true,
 			},
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 
@@ -241,7 +241,7 @@ func TestIntegration_FieldMapping(t *testing.T) {
 	var capturedRequest TelemetryRequest
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		body, _ := io.ReadAll(r.Body)
-		json.Unmarshal(body, &capturedRequest)
+		_ = json.Unmarshal(body, &capturedRequest)
 		w.WriteHeader(http.StatusOK)
 	}))
 	defer server.Close()