[PECOBLR-1146] Feature Flag Cache with Reference Counting#300
Closed
samikshya-db wants to merge 1 commit intomainfrom
Closed
[PECOBLR-1146] Feature Flag Cache with Reference Counting#300samikshya-db wants to merge 1 commit intomainfrom
samikshya-db wants to merge 1 commit intomainfrom
Conversation
Implements per-host feature flag caching with reference counting for telemetry control. Key features: - Per-host singleton cache to prevent rate limiting - Reference counting tied to connection lifecycle - 15-minute TTL with automatic refresh - Thread-safe concurrent access using RWMutex - HTTP integration with Databricks feature flag API - Fallback to cached value on fetch errors Comprehensive test coverage includes: - Reference counting increment/decrement - Cache expiration and refresh logic - Concurrent access safety - HTTP fetch success/failure scenarios - Multiple host management 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
Closing because #304 is merged already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement Phase 2 (Per-Host Management - Part 1) of telemetry for the Go driver: feature flag cache with reference counting to prevent rate limiting.
Changes
featureFlagCachestruct with singleton pattern for global cache managementfeatureFlagContextstruct with per-host state (enabled flag, lastFetched, refCount)getOrCreateContext()to increment reference count when connections openreleaseContext()to decrement reference count and cleanup when connections closeisTelemetryEnabled()with 15-minute TTL cache and automatic refreshfetchFeatureFlag()for HTTP integration with Databricks feature flag APIKey Features
sync.RWMutexfor concurrent accessTesting
JIRA
Closes PECOBLR-1146
Part of PECOBLR-1143
Design Document
See
telemetry/DESIGN.mdSection 3.1 for detailed design specification.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com