Commit 01128d0
committed
fix: bump uuid to ^11, sinon back to ^17, pin TypeScript to 5.5.4
Three coupled changes to clear the remaining OSV finding cleanly:
1. uuid: ^9.0.0 -> ^11.1.1 (both top-level dep and the override that
constrains thrift's transitive uuid). Clears GHSA-w5hq-g745-h8pq
(CVSS 7.5, buffer-bounds bug in v3/v5/v6). Driver uses only v4,
stringify, NIL — not the vulnerable functions — but the CVE
surfaces in consumers' own OSV/Snyk scans against our lockfile,
so we need it actually patched, not just suppressed.
2. typescript: ^4.9.3 -> 5.5.4 (exact pin). uuid@11's d.ts uses
`export type *` (TS 5.0+). TypeScript is pinned to <5.6 because
TS 5.6+ tells @types/node to use its newer generic Buffer
declaration (Buffer<TArrayBuffer extends ArrayBufferLike>),
which would leak into our published d.ts as
`Buffer<ArrayBufferLike>[]` and break consumers on stale
@types/node. TS 5.5 uses the ts5.6/ fallback shim that keeps
the emit as plain `Buffer[]` — byte-equivalent to today's d.ts.
3. sinon: ^19.0.5 -> ^17.0.2. The sinon@19 bump in this PR was
redundant for security (all CVEs in sinon's transitive tree are
covered by our existing overrides on flatted, serialize-javascript,
etc.) and broke the FeatureFlagCache.test.ts upstream test on
Node 16 due to sinon 19's broader fake-timer faking
(@sinonjs/fake-timers 13 vs 11). Reverting to ^17.0.2 restores
the test pass with no CVE re-introduction.
Source change in FederationProvider.ts: TS 5 caught a real but
benign type incompatibility between node-fetch's AbortSignal shim
and the native AbortSignal that TS 4 missed. Cast the controller
signal through `any` — the two are runtime-compatible; this is a
typings-only mismatch.
Verified locally:
- npm ci + npm test pass on Node 16.20.2 and 18.20.8 (904 passing)
- OSV-Scanner reports zero findings against the regenerated lockfile
- Emitted dist/*.d.ts and dist/*.js diff against current main only
in cosmetic ways (removed obsolete /// <reference> directives,
preserved source comments, TS 5's improved enum/export emit) —
no behavior changes for consumers
Co-authored-by: Isaac
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>1 parent 1c00362 commit 01128d0
3 files changed
Lines changed: 86 additions & 108 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
167 | 171 | | |
168 | 172 | | |
169 | 173 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
0 commit comments