Commit 0fcd03e
committed
feat(sea): surface numModifiedRows on the async (runAsync) path
The sync path already reports numModifiedRows for SEA DML; the async
(submitStatement) path returned all-null because readRichStatusFields
short-circuited for asyncStatement (the rich accessors used to live only
on the terminal sync Statement).
Kernel 75bfa52 now derives a DML's count off the terminal GetStatement
poll the async path already makes (no extra fetch, gated so SELECTs are
untouched) and exposes the four extended-status accessors on the napi
AsyncStatement. This change reads them off the async handle:
- readRichStatusFields now reads off this.asyncStatement (extracted into
a shared readStatusFieldsFrom used by both the sync Statement and the
async AsyncStatement);
- status() surfaces the fields on the async Succeeded state (the same
GetStatement poll it just made carried them) — without materialising
the result, so async streaming is unaffected.
Bumps KERNEL_REV to 75bfa52 and updates the napi contract
(native/sea/index.d.ts) with the new AsyncStatement accessors.
Verified live (pecotesting http_path2): SEA async INSERT/UPDATE/DELETE/
MERGE report numModifiedRows 3/2/1/2 — matching the sync path and Thrift
— with fetchAll() unchanged and SELECT carrying no count.
Co-authored-by: Isaac1 parent e202af3 commit 0fcd03e
4 files changed
Lines changed: 109 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
414 | | - | |
415 | | - | |
416 | | - | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
417 | 419 | | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
418 | 423 | | |
419 | 424 | | |
420 | 425 | | |
| |||
496 | 501 | | |
497 | 502 | | |
498 | 503 | | |
499 | | - | |
500 | | - | |
501 | | - | |
502 | | - | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
503 | 512 | | |
504 | | - | |
| 513 | + | |
505 | 514 | | |
506 | 515 | | |
507 | 516 | | |
| |||
517 | 526 | | |
518 | 527 | | |
519 | 528 | | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
524 | 551 | | |
525 | 552 | | |
526 | | - | |
| 553 | + | |
527 | 554 | | |
528 | 555 | | |
529 | 556 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
151 | 178 | | |
152 | 179 | | |
153 | 180 | | |
| |||
942 | 969 | | |
943 | 970 | | |
944 | 971 | | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
945 | 1002 | | |
946 | 1003 | | |
947 | 1004 | | |
| |||
0 commit comments