Commit 1986809
committed
feat(thrift): per-statement metricViewMetadata knob on ExecuteStatementOptions
Add `metricViewMetadata?: boolean` to `ExecuteStatementOptions`. When true,
the Thrift backend forwards
`spark.databricks.optimizer.enableMetricViewMetadata=true` via the request
`confOverlay`, alongside any `query_tags` already serialized there. The
option is per-statement only and does not persist across queries.
The SEA backend will route the same key through napi `statementConf` once
the kernel statement-options surface lands; until then the option is
honored only on Thrift. Documented in the public option JSDoc so users do
not silently lose the conf on SEA.
Unit tests assert the option appears in the outgoing `TExecuteStatementReq`
when set, is omitted when unset or `false`, and coexists with `queryTags`
in the same `confOverlay`.
Audit refs: rows 1.17 and 2.18 of
sea-workflow/audits/2026-05-28-cross-driver-audit.md (F12 in the PR #347
audit).
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>1 parent a3bf320 commit 1986809
3 files changed
Lines changed: 76 additions & 0 deletions
File tree
- lib
- contracts
- thrift-backend
- tests/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
30 | 41 | | |
31 | 42 | | |
32 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
191 | 198 | | |
192 | 199 | | |
193 | 200 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
301 | 359 | | |
302 | 360 | | |
303 | 361 | | |
| |||
0 commit comments