Commit 27851cc
committed
fix(sea): forward queryTags through executeStatement (was silently dropped)
`ExecuteStatementOptions.queryTags` is a public option but the SEA
executeStatement never forwarded it, so tags were silently dropped versus
the Thrift backend. Serialise them JS-side via `serializeQueryTags` into the
conf overlay's `query_tags` key (the same wire shape Thrift produces) — not
via the napi `queryTags` field, which is a `HashMap<String,String>` that
can't represent a null-valued tag, and the kernel rejects setting both the
field and a `query_tags` conf key. Null-valued tags round-trip as key-only
segments.
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>1 parent 88c10aa commit 27851cc
2 files changed
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
168 | 169 | | |
169 | 170 | | |
170 | 171 | | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
171 | 182 | | |
172 | 183 | | |
173 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
382 | 399 | | |
383 | 400 | | |
384 | 401 | | |
| |||
0 commit comments