Skip to content

Commit 3ade6d9

Browse files
committed
ci(sea): inject E2E_* vars so tests/e2e/sea actually runs (config.ts process.exit fix)
The tests/e2e/sea suite reads creds from two sources: most tests read DATABRICKS_PECOTESTING_* directly (already injected), but e2e-smoke.test.ts imports tests/e2e/utils/config.ts, which process.exit(1)s at module load if any E2E_* var is unset — aborting the whole mocha run before it starts. Mirror main.yml's e2e-test job mapping (E2E_HOST/PATH/ACCESS_TOKEN + CATALOG/SCHEMA/ VOLUME/TABLE_SUFFIX) so the suite loads and runs. Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
1 parent 11b6c66 commit 3ade6d9

1 file changed

Lines changed: 16 additions & 3 deletions

File tree

.github/workflows/kernel-e2e.yml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,12 +182,25 @@ jobs:
182182
checks: write
183183
id-token: write
184184
env:
185-
# SEA e2e tests gate on the DATABRICKS_PECOTESTING_* vars; map the
186-
# warehouse secrets onto them so the suite actually runs (it skips
187-
# when they are absent).
185+
# The tests/e2e/sea suite reads creds from TWO sources, so we set both:
186+
#
187+
# 1. Most SEA tests (execution, results, interval-*) read the
188+
# DATABRICKS_PECOTESTING_* vars directly and skip when absent.
188189
DATABRICKS_PECOTESTING_SERVER_HOSTNAME: ${{ secrets.DATABRICKS_HOST }}
189190
DATABRICKS_PECOTESTING_HTTP_PATH: ${{ secrets.TEST_PECO_WAREHOUSE_HTTP_PATH }}
190191
DATABRICKS_PECOTESTING_TOKEN_PERSONAL: ${{ secrets.DATABRICKS_TOKEN }}
192+
#
193+
# 2. `e2e-smoke.test.ts` imports tests/e2e/utils/config.ts, which
194+
# `process.exit(1)`s at module load if ANY E2E_* var is unset — which
195+
# would abort the whole `tests/e2e/sea/**` mocha run before it starts.
196+
# Mirror main.yml's e2e-test job mapping so the suite loads + runs.
197+
E2E_HOST: ${{ secrets.DATABRICKS_HOST }}
198+
E2E_PATH: ${{ secrets.TEST_PECO_WAREHOUSE_HTTP_PATH }}
199+
E2E_ACCESS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }}
200+
E2E_CATALOG: peco
201+
E2E_SCHEMA: default
202+
E2E_VOLUME: e2etests
203+
E2E_TABLE_SUFFIX: ${{ github.sha }}
191204
steps:
192205
- name: Check out driver
193206
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

0 commit comments

Comments
 (0)