Commit 6fa4f1f
committed
fix(sea): F3 round-3 — eslint no-unused-vars on 4 underscore-prefix args
DA F3 round-1 M3 finding: airbnb-typescript's `no-unused-vars` rule
does not honor the `_`-prefix convention, so the 4 args in this
test file that are interface-mandated but unused (the IDBSQLLogger
`log(_level, _message)` noop method and the sinon spy
`(_sql, _options) => stmt`) were reported as errors.
Verified the rule config: `.eslintrc` uses
`airbnb-typescript/base` which inherits airbnb-base's
`no-unused-vars` with no `argsIgnorePattern` override.
Two-line fix: `// eslint-disable-next-line` directly above each
site. Both args remain in the signature because they're shape-
mandated by the consumer (IDBSQLLogger interface, sinon spy
function type matching SeaNativeConnection.executeStatement).
Verified `yarn lint` no longer emits errors for
`tests/unit/sea/execution-query-tags.test.ts`. Pre-existing lint
errors on `operation-lifecycle-e2e.test.ts` and
`SeaSessionBackend.ts` are upstream on `sea-auth-u2m` and not
introduced or addressed by this commit.
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>1 parent 0dc1b2c commit 6fa4f1f
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| |||
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| 88 | + | |
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
| |||
0 commit comments